Skip to content

Commit bf306b6

Browse files
Secrets: rename Slug into Unique identifier
1 parent 4ce2cfd commit bf306b6

6 files changed

Lines changed: 12 additions & 12 deletions

File tree

frontend/src/app/components/secrets/audit-log-dialog/audit-log-dialog.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<h2 mat-dialog-title>
22
<mat-icon class="title-icon">history</mat-icon>
3-
Audit Log: {{data.secret.slug}}
3+
Audit Log: <span class="secret-identifier">{{data.secret.slug}}</span>
44
</h2>
55

66
<mat-dialog-content>

frontend/src/app/components/secrets/create-secret-dialog/create-secret-dialog.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@ <h2 mat-dialog-title>Create Secret</h2>
33
<mat-dialog-content>
44
<form [formGroup]="form" (ngSubmit)="onSubmit()" id="createSecretForm">
55
<mat-form-field appearance="outline" class="full-width">
6-
<mat-label>Slug</mat-label>
6+
<mat-label>Unique Identifier</mat-label>
77
<input matInput formControlName="slug"
88
placeholder="e.g., api-key, database-password"
99
data-testid="create-secret-slug-input">
10-
<mat-hint>Unique identifier (letters, numbers, hyphens, underscores)</mat-hint>
10+
<mat-hint>Use letters, numbers, hyphens, and underscores (no spaces)</mat-hint>
1111
<mat-error *ngIf="form.get('slug')?.invalid">{{slugError}}</mat-error>
1212
</mat-form-field>
1313

frontend/src/app/components/secrets/create-secret-dialog/create-secret-dialog.component.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,9 @@ export class CreateSecretDialogComponent {
7272

7373
get slugError(): string {
7474
const control = this.form.get('slug');
75-
if (control?.hasError('required')) return 'Slug is required';
76-
if (control?.hasError('maxlength')) return 'Slug must be 255 characters or less';
77-
if (control?.hasError('pattern')) return 'Only letters, numbers, hyphens, and underscores allowed';
75+
if (control?.hasError('required')) return 'Unique identifier is required';
76+
if (control?.hasError('maxlength')) return 'Unique identifier must be 255 characters or less';
77+
if (control?.hasError('pattern')) return 'Only letters, numbers, hyphens, and underscores allowed (no spaces)';
7878
return '';
7979
}
8080

frontend/src/app/components/secrets/delete-secret-dialog/delete-secret-dialog.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ <h2 mat-dialog-title>Delete Secret</h2>
44
<div class="warning-container">
55
<mat-icon class="warning-icon">warning</mat-icon>
66
<div class="warning-content">
7-
<p>Are you sure you want to delete the secret <strong>{{data.secret.slug}}</strong>?</p>
7+
<p>Are you sure you want to delete the secret with identifier <strong>{{data.secret.slug}}</strong>?</p>
88
<p class="warning-details">
99
This action cannot be undone. The secret value and all associated audit logs will be permanently removed.
1010
</p>

frontend/src/app/components/secrets/edit-secret-dialog/edit-secret-dialog.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<h2 mat-dialog-title>Edit Secret: {{data.secret.slug}}</h2>
1+
<h2 mat-dialog-title>Edit Secret: <span class="secret-identifier">{{data.secret.slug}}</span></h2>
22

33
<mat-dialog-content>
44
<form [formGroup]="form" (ngSubmit)="onSubmit()" id="editSecretForm">

frontend/src/app/components/secrets/secrets.component.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ <h1 class="mat-h1">Company Secrets</h1>
1414
<input matInput
1515
[(ngModel)]="searchQuery"
1616
(ngModelChange)="onSearchChange($event)"
17-
placeholder="Search by slug..."
17+
placeholder="Search by unique identifier..."
1818
data-testid="secrets-search-input">
1919
<mat-icon matSuffix>search</mat-icon>
2020
</mat-form-field>
@@ -41,12 +41,12 @@ <h3>No secrets found</h3>
4141
</div>
4242

4343
<table *ngIf="!loading && secrets.length > 0" mat-table [dataSource]="secrets" class="mat-elevation-z2 secrets-table">
44-
<!-- Slug Column -->
44+
<!-- Unique Identifier Column -->
4545
<ng-container matColumnDef="slug">
46-
<th mat-header-cell *matHeaderCellDef>Slug</th>
46+
<th mat-header-cell *matHeaderCellDef>Unique Identifier</th>
4747
<td mat-cell *matCellDef="let secret; let i = index"
4848
class="secrets-cell secrets-cell_slug"
49-
data-label="Slug"
49+
data-label="Unique Identifier"
5050
attr.data-testid="secret-slug-{{i}}-cell">
5151
<span class="slug-text">{{secret.slug}}</span>
5252
</td>

0 commit comments

Comments
 (0)