refactor: enhance error handling with type safety in connection use cases

Author: Artuomka

backend/src/entities/connection/connection.controller.ts

@@ -536,10 +536,11 @@ export class ConnectionController {
 		};
 		try {
 			await validateCreateConnectionData(inputData);
-		} catch (e) {
+		} catch (e: unknown) {
+			const err = e as { response?: { message?: string }; message?: string };
 			return {
 				result: false,
-				message: e?.response?.message || e?.message || Messages.CONNECTION_TYPE_INVALID,
+				message: err?.response?.message || err?.message || Messages.CONNECTION_TYPE_INVALID,
 			};
 		}
 		const result = await this.testConnectionUseCase.execute(inputData, InTransactionEnum.OFF);

backend/src/entities/connection/use-cases/find-all-users-in-connection.use.case.ts

@@ -7,6 +7,8 @@ import { UserEntity } from '../../user/user.entity.js';
 import { buildFoundUserDto } from '../../user/utils/build-found-user.dto.js';
 import { IFindUsersInConnection } from './use-cases.interfaces.js';
 
+type UserWithoutRelations = Omit<UserEntity, 'connections' | 'groups'>;
+
 @Injectable()
 export class FindAllUsersInConnectionUseCase
 	extends AbstractUseCase<string, Array<FoundUserDto>>
@@ -20,10 +22,8 @@ export class FindAllUsersInConnectionUseCase
 	}
 
 	protected async implementation(connectionId: string): Promise<Array<FoundUserDto>> {
-		const userInConnection = await this._dbContext.userRepository.findAllUsersInConnection(connectionId);
-		return userInConnection.map((user) => {
-			//todo fix type after repository types are fixed
-			return buildFoundUserDto(user as UserEntity);
-		});
+		const userInConnection: UserWithoutRelations[] =
+			await this._dbContext.userRepository.findAllUsersInConnection(connectionId);
+		return userInConnection.map((user) => buildFoundUserDto(user as UserEntity));
 	}
 }

backend/src/entities/connection/use-cases/find-one-connection.use.case.ts

@@ -85,7 +85,7 @@ export class FindOneConnectionUseCase
 		if (filteredConnection.masterEncryption && inputData.masterPwd && accessLevel !== AccessLevelEnum.none) {
 			try {
 				filteredConnection = Encryptor.decryptConnectionCredentials(connection, inputData.masterPwd);
-			} catch (e) {
+			} catch (e: unknown) {
 				console.error('-> Error decrypting connection credentials', e);
 				throw new HttpException(
 					{