Skip to content

temporary disable large dataset checks and related logic in data access objects for MySQL, PostgreSQL, and MSSQL #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Artuomka merged 1 commit into from
Apr 15, 2025
Merged

temporary disable large dataset checks and related logic in data access objects for MySQL, PostgreSQL, and MSSQL #1142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions shared-code/src/data-access-layer/data-access-objects/data-access-object-mssql.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,17 +529,16 @@ WHERE TABLE_TYPE = 'VIEW'
: DAO_CONSTANTS.DEFAULT_PAGINATION.perPage;

const knex = await this.configureKnex();
const [rowsCount, tableStructure, tableSchema] = await Promise.all([
this.getRowsCount(tableName, null),
const [tableStructure, tableSchema] = await Promise.all([
this.getTableStructure(tableName),
this.getSchemaName(tableName),
]);

const availableFields = this.findAvailableFields(tableSettings, tableStructure);

if (rowsCount >= DAO_CONSTANTS.LARGE_DATASET_ROW_LIMIT) {
throw new Error(ERROR_MESSAGES.DATA_IS_TO_LARGE);
}
// if (rowsCount >= DAO_CONSTANTS.LARGE_DATASET_ROW_LIMIT) {
// throw new Error(ERROR_MESSAGES.DATA_IS_TO_LARGE);
// }

if (tableSchema) {
tableName = `${tableSchema}.[${tableName}]`;
Expand Down
16 changes: 9 additions & 7 deletions shared-code/src/data-access-layer/data-access-objects/data-access-object-mysql.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,14 +588,16 @@ export class DataAccessObjectMysql extends BasicDataAccessObject implements IDat
const offset = (page - 1) * perPage;
const knex = await this.configureKnex();

const [{ large_dataset }, tableStructure] = await Promise.all([
this.getRowsCount(knex, null, tableName, this.connection.database),
this.getTableStructure(tableName),
]);
// const [{ large_dataset }, tableStructure] = await Promise.all([
// this.getRowsCount(knex, null, tableName, this.connection.database),
// this.getTableStructure(tableName),
// ]);

if (large_dataset) {
throw new Error(ERROR_MESSAGES.DATA_IS_TO_LARGE);
}
const tableStructure = await this.getTableStructure(tableName);

// if (large_dataset) {
// throw new Error(ERROR_MESSAGES.DATA_IS_TO_LARGE);
// }

const availableFields = this.findAvailableFields(settings, tableStructure);

Expand Down
19 changes: 11 additions & 8 deletions shared-code/src/data-access-layer/data-access-objects/data-access-object-postgres.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,16 +590,19 @@ export class DataAccessObjectPostgres extends BasicDataAccessObject implements I
const offset = (page - 1) * perPage;
const knex = await this.configureKnex();

const tableSchema = this.connection.schema ?? 'public';
const [{ large_dataset }, tableStructure] = await Promise.all([
this.getRowsCount(knex, null, tableName, tableSchema),
this.getTableStructure(tableName),
]);
// const tableSchema = this.connection.schema ?? 'public';

// const [{ large_dataset }, tableStructure] = await Promise.all([
// this.getRowsCount(knex, null, tableName, tableSchema),
// this.getTableStructure(tableName),
// ]);

const tableStructure = await this.getTableStructure(tableName);
const availableFields = this.findAvailableFields(settings, tableStructure);

if (large_dataset) {
throw new Error(ERROR_MESSAGES.DATA_IS_TO_LARGE);
}
// if (large_dataset) {
// throw new Error(ERROR_MESSAGES.DATA_IS_TO_LARGE);
// }
const rowsAsStream = knex(tableName)
.withSchema(this.connection.schema ?? 'public')
.select(availableFields)
Expand Down