Skip to content

restore fields in common table settings #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Artuomka merged 4 commits into from
Jan 21, 2026
Merged

restore fields in common table settings #1513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36fe5f0
Update list_fields assignment to prioritize personalTableSettings ove…
Artuomka Jan 21, 2026
e1f8b49
Add end-to-end tests for personal and common table settings prioritiz…
Artuomka Jan 21, 2026
4cf5dac
Enhance table settings handling by adding columns_view and updating s…
Artuomka Jan 21, 2026
3ba33f4
Skip test for personal table settings priority when both settings exist
Artuomka Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions backend/src/entities/table-settings/application/data-structures/create-table-settings.ds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,16 @@ export class CreateTableSettingsDs {

@ApiProperty()
allow_csv_import: boolean;

@ApiProperty({ required: false})

Copilot AI Jan 21, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a spacing inconsistency in the ApiProperty decorator. It should be required: false (with a space after the colon) to match the formatting style of the other decorators in this file.

Suggested change
@ApiProperty({ required: false})
@ApiProperty({ required: false })

Copilot uses AI. Check for mistakes.
list_per_page?: number;

@ApiProperty({ isArray: true, type: 'string', required: false })

Copilot AI Jan 21, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ApiProperty decorator uses a string literal 'string' instead of the proper type. It should use type: String (capital S) to follow NestJS/Swagger conventions consistently with other array properties in this codebase.

Copilot uses AI. Check for mistakes.
list_fields?: Array<string>;

@ApiProperty({ required: false })
ordering?: string;

@ApiProperty({ required: false })
ordering_field?: string;
}
100 changes: 56 additions & 44 deletions backend/src/entities/table-settings/application/data-structures/found-table-settings.ds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,69 +4,81 @@ import { TableActionEntity } from '../../../table-actions/table-actions-module/t
import { TableWidgetEntity } from '../../../widget/table-widget.entity.js';

export class FoundTableSettingsDs {
@ApiProperty()
id: string;
@ApiProperty()
id: string;

@ApiProperty()
table_name: string;
@ApiProperty()
table_name: string;

@ApiProperty()
display_name: string;
@ApiProperty()
display_name: string;

@ApiProperty({ isArray: true, type: String })
search_fields: Array<string>;
@ApiProperty({ isArray: true, type: String })
search_fields: Array<string>;

@ApiProperty({ isArray: true, type: String })
excluded_fields: Array<string>;
@ApiProperty({ isArray: true, type: String })
excluded_fields: Array<string>;

@ApiProperty({ isArray: true, type: String })
identification_fields: Array<string>;
@ApiProperty({ isArray: true, type: String })
identification_fields: Array<string>;

@ApiProperty()
identity_column: string;
@ApiProperty()
identity_column: string;

@ApiProperty({ isArray: true, type: String })
readonly_fields: Array<string>;
@ApiProperty({ isArray: true, type: String })
readonly_fields: Array<string>;

@ApiProperty({ isArray: true, type: String })
sensitive_fields: Array<string>;
@ApiProperty({ isArray: true, type: String })
sensitive_fields: Array<string>;

@ApiProperty({ isArray: true, type: String })
sortable_by: Array<string>;
@ApiProperty({ isArray: true, type: String })
sortable_by: Array<string>;

@ApiProperty({ isArray: true, type: String })
autocomplete_columns: Array<string>;
@ApiProperty({ isArray: true, type: String })
autocomplete_columns: Array<string>;

@ApiProperty({ isArray: true, type: String })
columns_view: Array<string>;
@ApiProperty({ isArray: true, type: String })
columns_view: Array<string>;

@ApiProperty()
connection_id: string;
@ApiProperty()
connection_id: string;

@ApiProperty({ isArray: true, type: CustomFieldsEntity })
custom_fields: Array<CustomFieldsEntity>;
@ApiProperty({ isArray: true, type: CustomFieldsEntity })
custom_fields: Array<CustomFieldsEntity>;

@ApiProperty({ isArray: true, type: TableWidgetEntity })
table_widgets: Array<TableWidgetEntity>;
@ApiProperty({ isArray: true, type: TableWidgetEntity })
table_widgets: Array<TableWidgetEntity>;

@ApiProperty({ isArray: true, type: TableActionEntity })
table_actions: Array<TableActionEntity>;
@ApiProperty({ isArray: true, type: TableActionEntity })
table_actions: Array<TableActionEntity>;

@ApiProperty()
can_add: boolean;
@ApiProperty()
can_add: boolean;

@ApiProperty()
can_delete: boolean;
@ApiProperty()
can_delete: boolean;

@ApiProperty()
can_update: boolean;
@ApiProperty()
can_update: boolean;

@ApiProperty()
icon: string;
@ApiProperty()
icon: string;

@ApiProperty()
allow_csv_export: boolean;
@ApiProperty()
allow_csv_export: boolean;

@ApiProperty()
allow_csv_import: boolean;
@ApiProperty()
allow_csv_import: boolean;

@ApiProperty({ isArray: true, type: 'string' })

Copilot AI Jan 21, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ApiProperty decorator uses a string literal 'string' instead of the proper type. It should use type: String (capital S) to follow NestJS/Swagger conventions consistently with other array properties in this file.

Suggested change
@ApiProperty({ isArray: true, type: 'string' })
@ApiProperty({ isArray: true, type: String })

Copilot uses AI. Check for mistakes.
list_fields: string[];

@ApiProperty()
list_per_page: number;

@ApiProperty()
ordering: string;

@ApiProperty()
ordering_field: string;
}
Loading
Loading