fix columns_view in table settings#1519
Merged
Merged
Conversation
…ability; add tests for personal table settings and ensure proper handling of missing fields and invalid data types.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes the columns_view field in table settings by ensuring it is properly passed from the controller to the persistence layer. It also adds comprehensive tests for personal table settings functionality with the columns_view field.
Changes:
- Added
columns_viewparameter extraction in table settings controller endpoints - Included
columns_viewin the data transfer objects (DTOs) and data structures - Updated the table settings entity builder to save the
columns_viewfield - Added tests verifying the priority of personal table settings
columns_viewover common table settings - Includes formatting changes (indentation from spaces to tabs) in test files
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| backend/test/ava-tests/saas-tests/table-settings-e2e.test.ts | Added 3 new tests for columns_view priority logic and reformatted existing tests |
| backend/test/ava-tests/non-saas-tests/non-saas-table-settings-e2e.test.ts | Added 3 new tests for columns_view priority and removed inline comments from existing tests |
| backend/src/entities/table-settings/common-table-settings/utils/build-new-table-settings-entity.ts | Added extraction and assignment of columns_view field |
| backend/src/entities/table-settings/common-table-settings/table-settings.controller.ts | Added columns_view parameter to POST and PUT endpoints |
| backend/src/entities/table-settings/common-table-settings/dto/create-table-settings.dto.ts | Added columns_view field to DTO and reformatted to use tabs |
| backend/src/entities/table-settings/application/data-structures/create-table-settings.ds.ts | Added columns_view field with API property decorator |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ability; add tests for personal table settings and ensure proper handling of missing fields and invalid data types.