Migrate s3 widget to signals#1535
Merged
Merged
Conversation
Migrate all three language widget components (display, record-view, edit) from decorator-based @Input/@output to Angular signal APIs (input, output, computed, signal). Update S3 widget template and CLAUDE.md coding conventions to require built-in control flow (@if, @for) over structural directives. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the ng-dynamic-component library from version 10.7.0 to 10.8.0 and migrates components to use the new SignalComponentIoModule for signal-based component I/O handling. The changes include importing the new module in the main application configuration and updating five component files to support the new signal-based dynamic component architecture.
Changes:
- Upgraded
ng-dynamic-componentpackage from^10.7.0to^10.8.0(resolving to version 10.8.2) - Added
SignalComponentIoModuleimport to main application configuration and five components that use dynamic component rendering - Applied code formatting improvements (indentation and line breaks) across modified TypeScript files
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/package.json | Updated ng-dynamic-component dependency version to ^10.8.0 |
| frontend/yarn.lock | Updated package lock with new ng-dynamic-component version 10.8.2 and checksum |
| frontend/src/main.ts | Added SignalComponentIoModule import and registration in application bootstrap |
| frontend/src/app/components/db-table-row-edit/db-table-row-edit.component.ts | Added SignalComponentIoModule import and module registration for dynamic widget rendering |
| frontend/src/app/components/dashboard/db-table-view/db-table-view.component.ts | Added SignalComponentIoModule with extensive formatting improvements |
| frontend/src/app/components/dashboard/db-table-view/db-table-row-view/db-table-row-view.component.ts | Added SignalComponentIoModule with comprehensive code formatting updates |
| frontend/src/app/components/dashboard/db-table-view/db-table-filters-dialog/db-table-filters-dialog.component.ts | Added SignalComponentIoModule with import reorganization and formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.