-
-
Notifications
You must be signed in to change notification settings - Fork 18
Editable in fast filters #1567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lyubov-voloshko
merged 3 commits into
rocket-admin:main
from
karinakharchenko:editable-in-fast-filters
Feb 5, 2026
Merged
Editable in fast filters #1567
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| .filters-content { | ||
| display: grid; | ||
| grid-template-columns: 32px auto 228px 0 1fr 120px; | ||
| grid-template-columns: 32px auto 228px 0 1fr 100px; | ||
| grid-column-gap: 8px; | ||
| align-content: flex-start; | ||
| align-items: center; | ||
|
|
@@ -22,7 +22,7 @@ | |
| } | ||
|
|
||
| .empty-conditions-container { | ||
| grid-column: 1 / span 6; | ||
| grid-column: 1 / span 5; | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 12px; | ||
|
|
@@ -118,10 +118,317 @@ | |
| top: 100%; | ||
| } | ||
|
|
||
| .dynamic-column-radio { | ||
| .quick-edit-header { | ||
| grid-column: 6; | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 4px; | ||
| justify-content: center; | ||
| margin-top: 8px; | ||
| margin-bottom: 16px; | ||
| } | ||
|
|
||
| .quick-edit-title { | ||
| font-size: 11px; | ||
| font-weight: 500; | ||
| text-transform: uppercase; | ||
| letter-spacing: 0.5px; | ||
| color: rgba(0, 0, 0, 0.5); | ||
| white-space: nowrap; | ||
| } | ||
|
|
||
| .quick-edit-info-icon { | ||
| font-size: 14px; | ||
| width: 14px; | ||
| height: 14px; | ||
| color: rgba(0, 0, 0, 0.35); | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| /* Quick edit help menu styles */ | ||
| ::ng-deep .quick-edit-help-menu { | ||
| max-width: none !important; | ||
| } | ||
|
|
||
| .quick-edit-help-content { | ||
| padding: 16px; | ||
| cursor: default; | ||
| } | ||
|
|
||
| .quick-edit-help-text { | ||
| margin: 0 0 12px 0; | ||
| font-size: 13px; | ||
| color: rgba(0, 0, 0, 0.7); | ||
| line-height: 1.4; | ||
| } | ||
|
|
||
| /* Animated example */ | ||
| .quick-edit-animated-example { | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 16px; | ||
| } | ||
|
|
||
| .example-toggle-animated { | ||
| flex-shrink: 0; | ||
| } | ||
|
|
||
| .toggle-track { | ||
| width: 36px; | ||
| height: 20px; | ||
| border-radius: 10px; | ||
| background-color: rgba(0, 0, 0, 0.25); | ||
| position: relative; | ||
| animation: toggleTrack 3s ease-in-out infinite; | ||
| } | ||
|
|
||
| .toggle-thumb { | ||
| width: 16px; | ||
| height: 16px; | ||
| border-radius: 50%; | ||
| background-color: #fff; | ||
| position: absolute; | ||
| top: 2px; | ||
| left: 2px; | ||
| box-shadow: 0 1px 3px rgba(0, 0, 0, 0.3); | ||
| animation: toggleThumb 3s ease-in-out infinite; | ||
| } | ||
|
|
||
| @keyframes toggleTrack { | ||
| 0%, 40% { | ||
| background-color: rgba(0, 0, 0, 0.25); | ||
| } | ||
| 50%, 90% { | ||
| background-color: #C177FC; | ||
| } | ||
| 100% { | ||
| background-color: rgba(0, 0, 0, 0.25); | ||
| } | ||
| } | ||
|
|
||
| @keyframes toggleThumb { | ||
| 0%, 40% { | ||
| left: 2px; | ||
| } | ||
| 50%, 90% { | ||
| left: 18px; | ||
| } | ||
| 100% { | ||
| left: 2px; | ||
| } | ||
| } | ||
|
|
||
| .example-filter-animated { | ||
| position: relative; | ||
| height: 36px; | ||
| min-width: 110px; | ||
| margin-top: 4px; | ||
| } | ||
|
|
||
| .example-chip-animated { | ||
| position: absolute; | ||
| top: 0; | ||
| left: 0; | ||
| background-color: rgba(0, 0, 0, 0.08); | ||
| border-radius: 16px; | ||
| padding: 5px 12px; | ||
| font-size: 12px; | ||
| color: rgba(0, 0, 0, 0.7); | ||
| white-space: nowrap; | ||
| animation: chipFade 3s ease-in-out infinite; | ||
| } | ||
|
|
||
| .example-editable-animated { | ||
| position: absolute; | ||
| top: 0; | ||
| left: 0; | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 4px; | ||
| background-color: transparent; | ||
| border: 1px solid #C177FC; | ||
| border-radius: 4px; | ||
| padding: 8px 8px 4px 8px; | ||
| opacity: 0; | ||
| animation: editableFade 3s ease-in-out infinite; | ||
| } | ||
|
|
||
| .example-editable-label { | ||
| position: absolute; | ||
| top: -8px; | ||
| left: 8px; | ||
| font-size: 10px; | ||
| color: #C177FC; | ||
| background-color: #fff; | ||
| padding: 0 4px; | ||
| } | ||
|
|
||
| .example-editable-value { | ||
| font-size: 12px; | ||
| color: rgba(0, 0, 0, 0.87); | ||
| display: flex; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .typing-text::after { | ||
| content: 'active'; | ||
| animation: typeText 3s ease-in-out infinite; | ||
| } | ||
|
|
||
| @keyframes typeText { | ||
| 0%, 40% { | ||
| content: ''; | ||
| } | ||
| 45% { | ||
| content: 'p'; | ||
| } | ||
| 50% { | ||
| content: 'pe'; | ||
| } | ||
| 55% { | ||
| content: 'pen'; | ||
| } | ||
| 60% { | ||
| content: 'pend'; | ||
| } | ||
| 65% { | ||
| content: 'pendi'; | ||
| } | ||
| 70%, 90% { | ||
| content: 'pending'; | ||
| } | ||
| 100% { | ||
| content: ''; | ||
| } | ||
| } | ||
|
|
||
| .example-typing-cursor { | ||
| font-size: 12px; | ||
| color: #C177FC; | ||
| font-weight: 300; | ||
| animation: cursorBlink 0.5s step-end infinite; | ||
| } | ||
|
|
||
| @keyframes cursorBlink { | ||
| 0%, 50% { | ||
| opacity: 1; | ||
| } | ||
| 51%, 100% { | ||
| opacity: 0; | ||
| } | ||
| } | ||
|
|
||
| @keyframes chipFade { | ||
| 0%, 40% { | ||
| opacity: 1; | ||
| } | ||
| 50%, 90% { | ||
| opacity: 0; | ||
| } | ||
| 100% { | ||
| opacity: 1; | ||
| } | ||
| } | ||
|
|
||
| @keyframes editableFade { | ||
| 0%, 40% { | ||
| opacity: 0; | ||
| } | ||
| 50%, 90% { | ||
| opacity: 1; | ||
| } | ||
| 100% { | ||
| opacity: 0; | ||
| } | ||
| } | ||
|
|
||
| @media (prefers-color-scheme: dark) { | ||
| .quick-edit-help-text { | ||
| color: rgba(255, 255, 255, 0.7); | ||
| } | ||
|
|
||
| .toggle-track { | ||
| animation: toggleTrackDark 3s ease-in-out infinite; | ||
| } | ||
|
|
||
| @keyframes toggleTrackDark { | ||
| 0%, 40% { | ||
| background-color: rgba(255, 255, 255, 0.3); | ||
| } | ||
| 50%, 90% { | ||
| background-color: #C177FC; | ||
| } | ||
| 100% { | ||
| background-color: rgba(255, 255, 255, 0.3); | ||
| } | ||
| } | ||
|
|
||
| .example-chip-animated { | ||
| background-color: rgba(255, 255, 255, 0.12); | ||
| color: rgba(255, 255, 255, 0.7); | ||
| } | ||
|
|
||
| .example-editable-animated { | ||
| background-color: transparent; | ||
| } | ||
|
|
||
| .example-editable-label { | ||
| color: #C177FC; | ||
| background-color: #424242; | ||
| } | ||
|
|
||
| .example-editable-value { | ||
| color: rgba(255, 255, 255, 0.87); | ||
| } | ||
|
|
||
| .example-typing-cursor { | ||
| color: #C177FC; | ||
| } | ||
| } | ||
|
|
||
| .quick-edit-toggle { | ||
| grid-column: 6; | ||
| margin-top: -16px; | ||
| align-self: center; | ||
| justify-self: center; | ||
| } | ||
|
|
||
| /* Hide default icons */ | ||
| .quick-edit-toggle ::ng-deep .mdc-switch__icons { | ||
| display: none; | ||
| } | ||
|
|
||
| /* Style the thumb to contain our icon */ | ||
| .quick-edit-toggle ::ng-deep .mdc-switch__handle { | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| } | ||
|
|
||
| /* Add lock icon when unchecked */ | ||
| .quick-edit-toggle ::ng-deep .mdc-switch__handle::after { | ||
| font-family: 'Material Icons'; | ||
| content: 'lock'; | ||
| font-size: 16px; | ||
| position: absolute; | ||
| color: #fff; | ||
| } | ||
|
|
||
| /* Add edit icon when checked */ | ||
| .quick-edit-toggle.mat-mdc-slide-toggle-checked ::ng-deep .mdc-switch__handle::after { | ||
| content: 'edit'; | ||
| font-size: 16px; | ||
| color: #fff; | ||
| } | ||
|
Comment on lines
+409
to
+422
|
||
|
|
||
| @media (prefers-color-scheme: dark) { | ||
| .quick-edit-title { | ||
| color: rgba(255, 255, 255, 0.5); | ||
| } | ||
|
|
||
| .quick-edit-info-icon { | ||
| color: rgba(255, 255, 255, 0.35); | ||
| } | ||
| } | ||
|
|
||
| .comparator-select-field { | ||
|
|
@@ -185,15 +492,6 @@ | |
| padding-bottom: 0; | ||
| } | ||
|
|
||
| .dynamic-column-radio ::ng-deep .mdc-form-field { | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 4px; | ||
| } | ||
|
|
||
| .dynamic-column-radio ::ng-deep .mdc-form-field>label { | ||
| white-space: nowrap; | ||
| } | ||
|
|
||
| .filter-save-form { | ||
| grid-column: 1 / span 6; | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The animations use the
infinitekeyword, which means they will run continuously as long as the help menu is open. This could impact performance if the menu stays open for extended periods. Consider adding animation-play-state controls or limiting the animation to run only a few times (e.g., using animation-iteration-count: 3) before stopping, which would reduce CPU usage while still demonstrating the feature effectively.