-
-
Notifications
You must be signed in to change notification settings - Fork 18
Feat/ibm plex mono table font #1578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
86be681
9a3e9e3
3c700d4
6273d30
a5f5d04
cbf0404
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,36 +1,37 @@ | ||
| .foreign-key-button { | ||
| background: transparent; | ||
| border: 1px solid transparent; | ||
| border-radius: 12px; | ||
| color: var(--color-accentedPalette-500); | ||
| cursor: pointer; | ||
| font-size: inherit; | ||
| padding: 2px 8px; | ||
| overflow: hidden; | ||
| text-overflow: ellipsis; | ||
| text-align: left; | ||
| max-width: 100%; | ||
| transition: background 100ms, border-color 100ms; | ||
| background: transparent; | ||
| border: 1px solid transparent; | ||
| border-radius: 12px; | ||
| color: var(--color-accentedPalette-500); | ||
|
Comment on lines
1
to
+5
|
||
| cursor: pointer; | ||
| font-family: inherit; | ||
| font-size: inherit; | ||
| padding: 2px 8px; | ||
| overflow: hidden; | ||
| text-overflow: ellipsis; | ||
| text-align: left; | ||
| max-width: 100%; | ||
| transition: | ||
| background 100ms, | ||
| border-color 100ms; | ||
| } | ||
|
|
||
| @media (prefers-color-scheme: dark) { | ||
| .foreign-key-button:hover{ | ||
| background-color: var(--color-accentedPalette-900); | ||
| border: 1px solid var(--color-accentedPalette-700); | ||
| } | ||
| .foreign-key-button:hover { | ||
| background-color: var(--color-accentedPalette-900); | ||
| border: 1px solid var(--color-accentedPalette-700); | ||
| } | ||
| } | ||
|
|
||
| @media (prefers-color-scheme: light) { | ||
| .foreign-key-button:hover{ | ||
| background-color: var(--color-accentedPalette-100); | ||
| border: 1px solid var(--color-accentedPalette-300); | ||
| } | ||
| .foreign-key-button:hover { | ||
| background-color: var(--color-accentedPalette-100); | ||
| border: 1px solid var(--color-accentedPalette-300); | ||
| } | ||
| } | ||
|
|
||
| .foreign-key-button_selected { | ||
| background-color: var(--color-accentedPalette-100); | ||
| border-radius: 12px; | ||
| border: 1px solid var(--color-accentedPalette-300); | ||
| background-color: var(--color-accentedPalette-100); | ||
| border-radius: 12px; | ||
| border: 1px solid var(--color-accentedPalette-300); | ||
| } | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,19 @@ | ||
| :host { | ||
| text-align: right; | ||
| } | ||
|
|
||
|
Comment on lines
+1
to
+4
|
||
| .field-display-id { | ||
| display: flex; | ||
| align-items: center; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: flex-end; | ||
| } | ||
|
|
||
| .field-value-id { | ||
| font-weight: 500; | ||
| flex-grow: 1; | ||
| font-weight: 500; | ||
| flex-grow: 1; | ||
| } | ||
|
|
||
| .field-copy-button { | ||
| right: auto; | ||
| left: 0; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,12 @@ | ||
| :host { | ||
| text-align: right; | ||
| } | ||
|
Comment on lines
+1
to
+3
|
||
|
|
||
| .field-display { | ||
| justify-content: flex-end; | ||
| } | ||
|
|
||
| .field-copy-button { | ||
| right: auto; | ||
| left: 0; | ||
| } | ||
|
Comment on lines
+1
to
+12
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,24 @@ | ||
| :host { | ||
| text-align: right; | ||
| } | ||
|
Comment on lines
+1
to
+3
|
||
|
|
||
| .field-display { | ||
| justify-content: flex-end; | ||
| } | ||
|
|
||
| .field-copy-button { | ||
| right: auto; | ||
| left: 0; | ||
| } | ||
|
|
||
| .out-of-threshold { | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 2px; | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 2px; | ||
| } | ||
|
|
||
| .out-of-threshold__icon { | ||
| font-size: 16px; | ||
| width: 16px; | ||
| height: 16px; | ||
| font-size: 16px; | ||
| width: 16px; | ||
| height: 16px; | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only IBM Plex Mono weights 400 and 500 are being included, but the table CSS uses bold text in places (e.g., mobile cell labels use
font-weight: bold). To avoid faux-bolding/rendering inconsistencies, either include the 700 weight CSS here as well or change the table styles to use an included weight (e.g., 500) instead ofbold.