Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,11 @@ export const dashboardCustomRepositoryExtension: IDashboardRepository = {
},

async findAllDashboardsByConnectionId(connectionId: string): Promise<DashboardEntity[]> {
return await this.find({
where: { connection_id: connectionId },
order: { created_at: 'DESC' },
});
const qb = this.createQueryBuilder('dashboard')
.leftJoinAndSelect('dashboard.widgets', 'widgets')
.where('dashboard.connection_id = :connectionId', { connectionId })
.orderBy('dashboard.created_at', 'DESC');
return await qb.getMany();
Comment on lines +23 to +27

Copilot AI Feb 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

findAllDashboardsByConnectionId now eagerly loads dashboard.widgets and is effectively identical to findAllDashboardsWithWidgetsByConnectionId. This makes the method name misleading and adds avoidable query/payload cost for callers that only need dashboards. Either revert this method to a lightweight find (no join) or remove/merge the duplicate API to keep semantics clear.

Suggested change
const qb = this.createQueryBuilder('dashboard')
.leftJoinAndSelect('dashboard.widgets', 'widgets')
.where('dashboard.connection_id = :connectionId', { connectionId })
.orderBy('dashboard.created_at', 'DESC');
return await qb.getMany();
return await this.find({
where: { connection_id: connectionId },
order: { created_at: 'DESC' },
});

Copilot uses AI. Check for mistakes.
},

async findAllDashboardsWithWidgetsByConnectionId(connectionId: string): Promise<DashboardEntity[]> {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,20 +1,35 @@
.chart-edit-layout {
display: flex;
height: calc(100vh - 64px);
}

.chart-edit-main {
flex: 1;
overflow-y: auto;
}

.chart-edit-page {
margin: 2em auto;
padding: 0 clamp(100px, 10vw, 200px);
display: flex;
flex-direction: column;
min-height: 100%;
padding: 0 clamp(40px, 5vw, 100px);
max-width: 1400px;
margin: 3em auto;
}

@media (width <= 900px) {
@media (width <= 600px) {
.chart-edit-page {
padding: 0 16px;
margin: 1.5em auto;
}
}

.chart-edit-header {
display: flex;
align-items: center;
gap: 16px;
margin-bottom: 24px;
margin-bottom: 32px;
flex-shrink: 0;
}

.chart-edit-header h1 {
Expand All @@ -31,11 +46,15 @@
display: flex;
flex-direction: column;
gap: 24px;
flex: 1;
overflow-y: auto;
padding-bottom: 24px;
}

.query-details {
display: flex;
gap: 16px;
margin-top: 8px;
}

@media (width <= 600px) {
Expand Down Expand Up @@ -210,17 +229,29 @@
display: flex;
justify-content: flex-end;
gap: 16px;
padding-top: 16px;
padding: 16px 0;
border-top: 1px solid rgba(0, 0, 0, 0.12);
background-color: #fff;
flex-shrink: 0;
position: sticky;
bottom: 0;
margin-top: auto;
}

@media (prefers-color-scheme: dark) {
.actions {
border-top-color: rgba(255, 255, 255, 0.12);
background-color: #1e1e1e;
}
}

.actions button mat-spinner {
display: inline-block;
margin-right: 8px;
}

.test-query-button .button-spinner {
display: inline-block;
vertical-align: middle;
margin-right: 4px;
}
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
<app-alert></app-alert>
<div class="chart-edit-layout">
<app-dashboards-sidebar
[connectionId]="connectionId()"
activeTab="queries">
</app-dashboards-sidebar>

<div class="chart-edit-page">
<div class="chart-edit-main">
<app-alert></app-alert>

<div class="chart-edit-page">
<div class="chart-edit-header">
<button mat-icon-button (click)="cancel()" matTooltip="Back to list">
<mat-icon>arrow_back</mat-icon>
</button>
<h1 class="mat-h1">{{ isEditMode() ? 'Edit Saved Query' : 'Create Saved Query' }}</h1>
<h1 class="mat-h1">{{ isEditMode() ? 'Edit Widget' : 'Create Widget' }}</h1>
</div>

<div *ngIf="loading()" class="loading-container">
Expand Down Expand Up @@ -41,9 +48,10 @@ <h3>SQL Query</h3>
<button mat-stroked-button
(click)="testQuery()"
[disabled]="!canTest()"
class="test-query-button"
data-testid="test-query-button">
<mat-icon *ngIf="!testing()">play_arrow</mat-icon>
<mat-spinner *ngIf="testing()" diameter="18"></mat-spinner>
<mat-spinner *ngIf="testing()" diameter="18" class="button-spinner"></mat-spinner>
{{ testing() ? 'Testing...' : 'Test Query' }}
</button>
</div>
Expand Down Expand Up @@ -148,18 +156,20 @@ <h3>Query Results ({{ testResults().length }} rows)</h3>
<mat-icon>info</mat-icon>
<p>Query executed successfully but returned no results.</p>
</div>
</div>

<div class="actions">
<button mat-button (click)="cancel()" data-testid="cancel-button">
Cancel
</button>
<button mat-flat-button color="primary"
(click)="saveQuery()"
[disabled]="!canSave()"
data-testid="save-query-button">
<mat-spinner *ngIf="saving()" diameter="18"></mat-spinner>
{{ saving() ? 'Saving...' : (isEditMode() ? 'Update Query' : 'Save Query') }}
</button>
<div class="actions" *ngIf="!loading()">
<button mat-button (click)="cancel()" data-testid="cancel-button">
Cancel
</button>
<button mat-flat-button color="primary"
(click)="saveQuery()"
[disabled]="!canSave()"
data-testid="save-query-button">
<mat-spinner *ngIf="saving()" diameter="18"></mat-spinner>
{{ saving() ? 'Saving...' : (isEditMode() ? 'Update Query' : 'Save Query') }}
</button>
</div>
</div>
</div>
</div>
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ describe('ChartEditComponent', () => {

mockUiSettingsService = {
editorTheme: 'vs-dark',
getUiSettings: vi.fn().mockReturnValue(of({})),
};

await TestBed.configureTestingModule({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import { ChartType, TestQueryResult } from 'src/app/models/saved-query';
import { ConnectionsService } from 'src/app/services/connections.service';
import { SavedQueriesService } from 'src/app/services/saved-queries.service';
import { UiSettingsService } from 'src/app/services/ui-settings.service';
import { DashboardsSidebarComponent } from '../../dashboards/dashboards-sidebar/dashboards-sidebar.component';
import { AlertComponent } from '../../ui-components/alert/alert.component';
import { ChartPreviewComponent } from '../chart-preview/chart-preview.component';

Expand All @@ -41,6 +42,7 @@ import { ChartPreviewComponent } from '../chart-preview/chart-preview.component'
CodeEditorModule,
ChartPreviewComponent,
AlertComponent,
DashboardsSidebarComponent,
],
})
export class ChartEditComponent implements OnInit {
Expand Down
Loading
Loading