-
-
Notifications
You must be signed in to change notification settings - Fork 18
Hosted PostgreSQL card UI tweaks and fixes #1696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lyubov-voloshko
merged 22 commits into
rocket-admin:main
from
karinakharchenko:hosted-card-tweaks
Apr 5, 2026
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
8df6d0b
feat: hosted PostgreSQL card UI tweaks
karinakharchenko 03bc34d
fix: properly save connection title in hosted DB success dialog
karinakharchenko b858a2e
fix: add Save button to connection name field and fix connectionId lo…
karinakharchenko 06bb0cd
fix: find new connection by diffing IDs and remove extra dialog buttons
karinakharchenko ab8b9bd
fix: improve dark theme for plan dialog hover and credentials dialog
karinakharchenko b28717b
fix: rename "Copy credentials" to "Copy connection string"
karinakharchenko 2f60458
fix: move password warning alert above credentials frame
karinakharchenko adcec48
feat: show checkmark and "Credentials copied" on copy button after click
karinakharchenko 8ff2e9b
fix: rewrite warning alert to emphasize saving credentials before clo…
karinakharchenko 688ba00
fix: shorten warning alert text
karinakharchenko 737a8fb
fix: hide Close button until credentials are copied
karinakharchenko 160ca11
fix: reset copy button after 2s, keep Close button visible
karinakharchenko cfab594
feat: separate rename dialog from credentials dialog
karinakharchenko 1aa1476
fix: align checkmark icon with text in copy button
karinakharchenko cf36573
fix: fetch full connection before renaming to preserve all fields
karinakharchenko 2da0145
fix: use safe connection properties endpoint for rename instead of PU…
karinakharchenko a41571e
hosted database: add new request to rename connection
lyubov-voloshko a755621
navbar: navigate user to company/hosted databses if current connectio…
lyubov-voloshko 34092ff
hosted databases: add title and move data base name below
lyubov-voloshko 369e550
hosted databases: consistent behaviour with creds dialog
lyubov-voloshko 57f5efd
connection list: update list on RA hosted db delete
lyubov-voloshko 2e09517
Merge branch 'main' into hosted-card-tweaks
lyubov-voloshko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
...onnections-list/hosted-database-rename-dialog/hosted-database-rename-dialog.component.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| .rename-dialog__content { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 16px; | ||
| min-width: min(100%, 28rem); | ||
| } | ||
|
|
||
| .rename-dialog__description { | ||
| margin: 0; | ||
| opacity: 0.65; | ||
| font-size: 14px; | ||
| } | ||
|
|
||
| .rename-dialog__field { | ||
| width: 100%; | ||
| } | ||
|
|
||
| .rename-dialog__actions { | ||
| gap: 8px; | ||
| padding-top: 8px; | ||
| } |
16 changes: 16 additions & 0 deletions
16
...nnections-list/hosted-database-rename-dialog/hosted-database-rename-dialog.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <h1 mat-dialog-title>Name your connection</h1> | ||
|
|
||
| <mat-dialog-content class="rename-dialog__content"> | ||
| <p class="rename-dialog__description">Give your hosted database a friendly name so you can find it easily.</p> | ||
| <mat-form-field appearance="outline" class="rename-dialog__field"> | ||
| <mat-label>Connection name</mat-label> | ||
| <input matInput [(ngModel)]="title" placeholder="e.g. Production DB, Staging, My App" (keyup.enter)="save()" cdkFocusInitial> | ||
| </mat-form-field> | ||
| </mat-dialog-content> | ||
|
|
||
| <mat-dialog-actions align="end" class="rename-dialog__actions"> | ||
| <button type="button" mat-button mat-dialog-close>Skip</button> | ||
| <button type="button" mat-flat-button color="accent" [disabled]="!title.trim() || saving" (click)="save()"> | ||
| {{ saving ? 'Saving...' : 'Save' }} | ||
| </button> | ||
| </mat-dialog-actions> |
52 changes: 52 additions & 0 deletions
52
...connections-list/hosted-database-rename-dialog/hosted-database-rename-dialog.component.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| import { Component, Inject, inject } from '@angular/core'; | ||
| import { FormsModule } from '@angular/forms'; | ||
| import { MatButtonModule } from '@angular/material/button'; | ||
| import { MatFormFieldModule } from '@angular/material/form-field'; | ||
| import { MatInputModule } from '@angular/material/input'; | ||
| import { MAT_DIALOG_DATA, MatDialogModule, MatDialogRef } from '@angular/material/dialog'; | ||
| import { firstValueFrom } from 'rxjs'; | ||
| import { CreatedHostedDatabase } from 'src/app/models/hosted-database'; | ||
| import { ConnectionsService } from 'src/app/services/connections.service'; | ||
|
|
||
| export interface HostedDatabaseRenameDialogData { | ||
| connectionId: string; | ||
| hostedDatabase: CreatedHostedDatabase; | ||
| } | ||
|
|
||
| @Component({ | ||
| selector: 'app-hosted-database-rename-dialog', | ||
| templateUrl: './hosted-database-rename-dialog.component.html', | ||
| styleUrls: ['./hosted-database-rename-dialog.component.css'], | ||
| imports: [MatDialogModule, MatButtonModule, MatFormFieldModule, MatInputModule, FormsModule], | ||
| }) | ||
| export class HostedDatabaseRenameDialogComponent { | ||
| private _connectionsService = inject(ConnectionsService); | ||
|
|
||
| title = ''; | ||
| saving = false; | ||
|
|
||
| constructor( | ||
| @Inject(MAT_DIALOG_DATA) public data: HostedDatabaseRenameDialogData, | ||
| private _dialogRef: MatDialogRef<HostedDatabaseRenameDialogComponent>, | ||
| ) { | ||
| this.title = data.hostedDatabase.databaseName || ''; | ||
| } | ||
|
|
||
| async save(): Promise<void> { | ||
| const title = this.title.trim(); | ||
| if (!title || this.saving) return; | ||
|
|
||
| this.saving = true; | ||
| try { | ||
| await firstValueFrom( | ||
| this._connectionsService.updateConnectionTitle(this.data.connectionId, title), | ||
| ); | ||
| this._connectionsService.fetchConnections().subscribe(); | ||
| this._dialogRef.close(title); | ||
| } catch { | ||
| this._dialogRef.close(); | ||
| } finally { | ||
| this.saving = false; | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The template no longer renders
.hosted-dialog__hint, but the dark-mode stylesheet still targets.hosted-dialog__hint. Consider removing/updating this selector (and any other hint-related rules) now that the hint was replaced by the warning element, to avoid dead CSS.