Skip to content

Component improvements #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lyubov-voloshko merged 4 commits into from
Apr 23, 2026
Merged

Component improvements #1718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb812fe
binary
gugu Apr 16, 2026
15f25eb
Rewrite binary widgets and pass binary as Buffer-JSON end-to-end
gugu Apr 17, 2026
b94e91f
Route binary widgets through shared byte-array helpers
gugu Apr 17, 2026
09dc580
Merge branch 'main' into component-improvements
lyubov-voloshko Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 27 additions & 17 deletions backend/src/entities/table/use-cases/add-row-in-table.use.case.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,35 +5,33 @@ import { buildDAOsTableSettingsDs } from '@rocketadmin/shared-code/dist/src/help
import AbstractUseCase from '../../../common/abstract-use.case.js';
import { IGlobalDatabaseContext } from '../../../common/application/global-database-context.interface.js';
import { BaseType } from '../../../common/data-injection.tokens.js';
import {
AmplitudeEventTypeEnum,
LogOperationTypeEnum,
OperationResultStatusEnum,
} from '../../../enums/index.js';
import { AmplitudeEventTypeEnum, LogOperationTypeEnum, OperationResultStatusEnum } from '../../../enums/index.js';
import { TableActionEventEnum } from '../../../enums/table-action-event-enum.js';
import { Messages } from '../../../exceptions/text/messages.js';
import { isObjectEmpty, toPrettyErrorsMsg } from '../../../helpers/index.js';
import { AmplitudeService } from '../../amplitude/amplitude.service.js';
import { CedarPermissionsService } from '../../cedar-authorization/cedar-permissions.service.js';
import { isTestConnectionUtil } from '../../connection/utils/is-test-connection-util.js';
import { TableActionActivationService } from '../../table-actions/table-actions-module/table-action-activation.service.js';
import { TableLogsService } from '../../table-logs/table-logs.service.js';
import { AddRowInTableDs } from '../application/data-structures/add-row-in-table.ds.js';
import { ReferencedTableNamesAndColumnsDs, TableRowRODs } from '../table-datastructures.js';
import { convertBinaryDataInRowUtil } from '../utils/convert-binary-data-in-row.util.js';
import { attachForeignColumnNames } from '../utils/attach-foreign-column-names.util.js';
import { buildTableSettingsForResponse } from '../utils/build-table-settings-for-response.util.js';
import { convertHexDataInRowUtil } from '../utils/convert-hex-data-in-row.util.js';
import { extractForeignKeysFromWidgets } from '../utils/extract-foreign-keys-from-widgets.util.js';
import { filterForeignKeysByReadPermission } from '../utils/filter-foreign-keys-by-permission.util.js';
import { formFullTableStructure } from '../utils/form-full-table-structure.js';
import { hashPasswordsInRowUtil } from '../utils/hash-passwords-in-row.util.js';
import {
enrichReferencedTablesWithDisplayNames,
filterReferencedTablesByPermission,
} from '../utils/process-referenced-tables.util.js';
import { processUuidsInRowUtil } from '../utils/process-uuids-in-row-util.js';
import { removePasswordsFromRowsUtil } from '../utils/remove-password-from-row.util.js';
import { getUserEmailForAgent, validateConnection } from '../utils/validate-connection.util.js';
import { validateTableRowUtil } from '../utils/validate-table-row.util.js';
import { CedarPermissionsService } from '../../cedar-authorization/cedar-permissions.service.js';
import { IAddRowInTable } from './table-use-cases.interface.js';
import { validateConnection, getUserEmailForAgent } from '../utils/validate-connection.util.js';
import { extractForeignKeysFromWidgets } from '../utils/extract-foreign-keys-from-widgets.util.js';
import { filterForeignKeysByReadPermission } from '../utils/filter-foreign-keys-by-permission.util.js';
import { attachForeignColumnNames } from '../utils/attach-foreign-column-names.util.js';
import { filterReferencedTablesByPermission, enrichReferencedTablesWithDisplayNames } from '../utils/process-referenced-tables.util.js';
import { buildTableSettingsForResponse } from '../utils/build-table-settings-for-response.util.js';

@Injectable()
export class AddRowInTableUseCase extends AbstractUseCase<AddRowInTableDs, TableRowRODs> implements IAddRowInTable {
Expand Down Expand Up @@ -98,7 +96,13 @@ export class AddRowInTableUseCase extends AbstractUseCase<AddRowInTableDs, Table
dao.getReferencedTableNamesAndColumns(tableName, userEmail),
]);

await filterReferencedTablesByPermission(referencedTableNamesAndColumns, userId, connectionId, masterPwd, this.cedarPermissions);
await filterReferencedTablesByPermission(
referencedTableNamesAndColumns,
userId,
connectionId,
masterPwd,
this.cedarPermissions,
);
const referencedTableNamesAndColumnsWithTablesDisplayNames = await enrichReferencedTablesWithDisplayNames(
referencedTableNamesAndColumns,
connectionId,
Expand All @@ -121,14 +125,21 @@ export class AddRowInTableUseCase extends AbstractUseCase<AddRowInTableDs, Table
let foreignKeysWithAutocompleteColumns: Array<ForeignKeyWithAutocompleteColumnsDS> = [];

foreignKeysWithKeysFromWidgets = await filterForeignKeysByReadPermission(
foreignKeysWithKeysFromWidgets, userId, connectionId, masterPwd, this.cedarPermissions,
foreignKeysWithKeysFromWidgets,
userId,
connectionId,
masterPwd,
this.cedarPermissions,
);

if (foreignKeysWithKeysFromWidgets?.length > 0) {
foreignKeysWithAutocompleteColumns = await Promise.all(
foreignKeysWithKeysFromWidgets.map((el) =>
attachForeignColumnNames(
el, userEmail, connectionId, dao,
el,
userEmail,
connectionId,
dao,
this._dbContext.tableSettingsRepository.findTableSettings.bind(this._dbContext.tableSettingsRepository),
).catch(() => el as ForeignKeyWithAutocompleteColumnsDS),
),
Expand Down Expand Up @@ -158,7 +169,6 @@ export class AddRowInTableUseCase extends AbstractUseCase<AddRowInTableDs, Table
operationResult = OperationResultStatusEnum.successfully;
addedRow = await dao.getRowByPrimaryKey(tableName, addedRowPrimaryKey, builtDAOsTableSettings, userEmail);
addedRow = removePasswordsFromRowsUtil(addedRow, tableWidgets);
addedRow = convertBinaryDataInRowUtil(addedRow, tableStructure);
return {
row: addedRow,
foreignKeys: foreignKeysWithAutocompleteColumns,
Expand Down
4 changes: 3 additions & 1 deletion backend/src/entities/table/use-cases/bulk-update-rows-in-table.use.case.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,14 @@ import { OperationResultStatusEnum } from '../../../enums/operation-result-statu
import { ExceptionOperations } from '../../../exceptions/custom-exceptions/exception-operation.js';
import { UnknownSQLException } from '../../../exceptions/custom-exceptions/unknown-sql-exception.js';
import { Messages } from '../../../exceptions/text/messages.js';
import { validateConnection, getUserEmailForAgent } from '../utils/validate-connection.util.js';
import { SuccessResponse } from '../../../microservices/saas-microservice/data-structures/common-responce.ds.js';
import { TableLogsService } from '../../table-logs/table-logs.service.js';
import { UpdateRowsInTableDs } from '../application/data-structures/update-rows-in-table.ds.js';
import { convertHexDataInPrimaryKeyUtil } from '../utils/convert-hex-data-in-primary-key.util.js';
import { convertHexDataInRowUtil } from '../utils/convert-hex-data-in-row.util.js';
import { hashPasswordsInRowUtil } from '../utils/hash-passwords-in-row.util.js';
import { processUuidsInRowUtil } from '../utils/process-uuids-in-row-util.js';
import { getUserEmailForAgent, validateConnection } from '../utils/validate-connection.util.js';
import { IBulkUpdateRowsInTable } from './table-use-cases.interface.js';

@Injectable()
Expand Down Expand Up @@ -94,6 +95,7 @@ export class BulkUpdateRowsInTableUseCase
try {
let processedNewValues = await hashPasswordsInRowUtil(newValues, tableWidgets);
processedNewValues = processUuidsInRowUtil(processedNewValues, tableWidgets);
processedNewValues = convertHexDataInRowUtil(processedNewValues, tableStructure);
await dao.bulkUpdateRowsInTable(tableName, processedNewValues, primaryKeys, userEmail);
operationResult = OperationResultStatusEnum.successfully;
return {
Expand Down
38 changes: 26 additions & 12 deletions backend/src/entities/table/use-cases/get-row-by-primary-key.use.case.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,24 @@ import { ExceptionOperations } from '../../../exceptions/custom-exceptions/excep
import { UnknownSQLException } from '../../../exceptions/custom-exceptions/unknown-sql-exception.js';
import { Messages } from '../../../exceptions/text/messages.js';
import { compareArrayElements } from '../../../helpers/index.js';
import { CedarPermissionsService } from '../../cedar-authorization/cedar-permissions.service.js';
import { buildActionEventDto } from '../../table-actions/table-action-rules-module/utils/build-found-action-event-dto.util.js';
import { GetRowByPrimaryKeyDs } from '../application/data-structures/get-row-by-primary-key.ds.js';
import { ReferencedTableNamesAndColumnsDs, TableRowRODs } from '../table-datastructures.js';
import { convertBinaryDataInRowUtil } from '../utils/convert-binary-data-in-row.util.js';
import { attachForeignColumnNames } from '../utils/attach-foreign-column-names.util.js';
import { buildTableSettingsForResponse } from '../utils/build-table-settings-for-response.util.js';
import { convertHexDataInPrimaryKeyUtil } from '../utils/convert-hex-data-in-primary-key.util.js';
import { extractForeignKeysFromWidgets } from '../utils/extract-foreign-keys-from-widgets.util.js';
import { filterForeignKeysByReadPermission } from '../utils/filter-foreign-keys-by-permission.util.js';
import { findAvailableFields } from '../utils/find-available-fields.utils.js';
import { formFullTableStructure } from '../utils/form-full-table-structure.js';
import {
enrichReferencedTablesWithDisplayNames,
filterReferencedTablesByPermission,
} from '../utils/process-referenced-tables.util.js';
import { removePasswordsFromRowsUtil } from '../utils/remove-password-from-row.util.js';
import { CedarPermissionsService } from '../../cedar-authorization/cedar-permissions.service.js';
import { getUserEmailForAgent, validateConnection } from '../utils/validate-connection.util.js';
import { IGetRowByPrimaryKey } from './table-use-cases.interface.js';
import { validateConnection, getUserEmailForAgent } from '../utils/validate-connection.util.js';
import { extractForeignKeysFromWidgets } from '../utils/extract-foreign-keys-from-widgets.util.js';
import { filterForeignKeysByReadPermission } from '../utils/filter-foreign-keys-by-permission.util.js';
import { attachForeignColumnNames } from '../utils/attach-foreign-column-names.util.js';
import { filterReferencedTablesByPermission, enrichReferencedTablesWithDisplayNames } from '../utils/process-referenced-tables.util.js';
import { buildTableSettingsForResponse } from '../utils/build-table-settings-for-response.util.js';

@Injectable()
export class GetRowByPrimaryKeyUseCase
Expand Down Expand Up @@ -102,15 +104,22 @@ export class GetRowByPrimaryKeyUseCase

tableForeignKeys = tableForeignKeys.concat(foreignKeysFromWidgets);
tableForeignKeys = await filterForeignKeysByReadPermission(
tableForeignKeys, userId, connectionId, masterPwd, this.cedarPermissions,
tableForeignKeys,
userId,
connectionId,
masterPwd,
this.cedarPermissions,
);

let foreignKeysWithAutocompleteColumns: Array<ForeignKeyWithAutocompleteColumnsDS> = [];
if (tableForeignKeys && tableForeignKeys.length > 0) {
foreignKeysWithAutocompleteColumns = await Promise.all(
tableForeignKeys.map((el) =>
attachForeignColumnNames(
el, userEmail, connectionId, dao,
el,
userEmail,
connectionId,
dao,
this._dbContext.tableSettingsRepository.findTableSettings.bind(this._dbContext.tableSettingsRepository),
).catch(() => el as ForeignKeyWithAutocompleteColumnsDS),
),
Expand All @@ -133,10 +142,15 @@ export class GetRowByPrimaryKeyUseCase
);
}
rowData = removePasswordsFromRowsUtil(rowData, tableWidgets);
rowData = convertBinaryDataInRowUtil(rowData, tableStructure);
const formedTableStructure = formFullTableStructure(tableStructure, tableSettings);

await filterReferencedTablesByPermission(referencedTableNamesAndColumns, userId, connectionId, masterPwd, this.cedarPermissions);
await filterReferencedTablesByPermission(
referencedTableNamesAndColumns,
userId,
connectionId,
masterPwd,
this.cedarPermissions,
);
const referencedTableNamesAndColumnsWithTablesDisplayNames = await enrichReferencedTablesWithDisplayNames(
referencedTableNamesAndColumns,
connectionId,
Expand Down
35 changes: 20 additions & 15 deletions backend/src/entities/table/use-cases/get-table-rows.use.case.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,15 @@ import Sentry from '@sentry/minimal';
import AbstractUseCase from '../../../common/abstract-use.case.js';
import { IGlobalDatabaseContext } from '../../../common/application/global-database-context.interface.js';
import { BaseType } from '../../../common/data-injection.tokens.js';
import {
AmplitudeEventTypeEnum,
LogOperationTypeEnum,
OperationResultStatusEnum,
} from '../../../enums/index.js';
import { AmplitudeEventTypeEnum, LogOperationTypeEnum, OperationResultStatusEnum } from '../../../enums/index.js';
import { ExceptionOperations } from '../../../exceptions/custom-exceptions/exception-operation.js';
import { UnknownSQLException } from '../../../exceptions/custom-exceptions/unknown-sql-exception.js';
import { Messages } from '../../../exceptions/text/messages.js';
import { hexToBinary, isBinary } from '../../../helpers/binary-to-hex.js';
import { Constants } from '../../../helpers/constants/constants.js';
import { isObjectEmpty } from '../../../helpers/index.js';
import { AmplitudeService } from '../../amplitude/amplitude.service.js';
import { CedarPermissionsService } from '../../cedar-authorization/cedar-permissions.service.js';
import { buildActionEventDto } from '../../table-actions/table-action-rules-module/utils/build-found-action-event-dto.util.js';
import { buildCreatedTableFilterRO } from '../../table-filters/utils/build-created-table-filters-response-object.util.js';
import { TableLogsService } from '../../table-logs/table-logs.service.js';
Expand All @@ -33,20 +30,19 @@ import { PersonalTableSettingsEntity } from '../../table-settings/personal-table
import { FoundTableRowsDs } from '../application/data-structures/found-table-rows.ds.js';
import { GetTableRowsDs } from '../application/data-structures/get-table-rows.ds.js';
import { FilteringFieldsDs } from '../table-datastructures.js';
import { attachForeignColumnNames } from '../utils/attach-foreign-column-names.util.js';
import { buildTableSettingsForResponse } from '../utils/build-table-settings-for-response.util.js';
import { extractForeignKeysFromWidgets } from '../utils/extract-foreign-keys-from-widgets.util.js';
import { filterForeignKeysByReadPermission } from '../utils/filter-foreign-keys-by-permission.util.js';
import { findAutocompleteFieldsUtil } from '../utils/find-autocomplete-fields.util.js';
import { findAvailableFields } from '../utils/find-available-fields.utils.js';
import { findFilteringFieldsUtil, parseFilteringFieldsFromBodyData } from '../utils/find-filtering-fields.util.js';
import { findOrderingFieldUtil } from '../utils/find-ordering-field.util.js';
import { formFullTableStructure } from '../utils/form-full-table-structure.js';
import { isHexString } from '../utils/is-hex-string.js';
import { processRowsUtil } from '../utils/process-found-rows-util.js';
import { CedarPermissionsService } from '../../cedar-authorization/cedar-permissions.service.js';
import { getUserEmailForAgent, validateConnection } from '../utils/validate-connection.util.js';
import { IGetTableRows } from './table-use-cases.interface.js';
import { validateConnection, getUserEmailForAgent } from '../utils/validate-connection.util.js';
import { extractForeignKeysFromWidgets } from '../utils/extract-foreign-keys-from-widgets.util.js';
import { filterForeignKeysByReadPermission } from '../utils/filter-foreign-keys-by-permission.util.js';
import { attachForeignColumnNames } from '../utils/attach-foreign-column-names.util.js';
import { buildTableSettingsForResponse } from '../utils/build-table-settings-for-response.util.js';

@Injectable()
export class GetTableRowsUseCase extends AbstractUseCase<GetTableRowsDs, FoundTableRowsDs> implements IGetTableRows {
Expand Down Expand Up @@ -166,22 +162,31 @@ export class GetTableRowsUseCase extends AbstractUseCase<GetTableRowsDs, FoundTa
Sentry.captureException(e);
throw new UnknownSQLException(e.message, ExceptionOperations.FAILED_TO_GET_ROWS_FROM_TABLE);
}
rows = processRowsUtil(rows, tableWidgets, tableStructure, tableCustomFields);
rows = processRowsUtil(rows, tableWidgets, tableCustomFields);

const foreignKeysFromWidgets = extractForeignKeysFromWidgets(tableWidgets);

tableForeignKeys = [...tableForeignKeys, ...foreignKeysFromWidgets];

tableForeignKeys = await filterForeignKeysByReadPermission(
tableForeignKeys, userId, connectionId, masterPwd, this.cedarPermissions,
tableForeignKeys,
userId,
connectionId,
masterPwd,
this.cedarPermissions,
);

if (tableForeignKeys && tableForeignKeys.length > 0) {
tableForeignKeys = await Promise.all(
tableForeignKeys.map((el) =>
attachForeignColumnNames(
el, userEmail, connectionId, dao,
this._dbContext.tableSettingsRepository.findTableSettingsPure.bind(this._dbContext.tableSettingsRepository),
el,
userEmail,
connectionId,
dao,
this._dbContext.tableSettingsRepository.findTableSettingsPure.bind(
this._dbContext.tableSettingsRepository,
),
).catch(() => el),
),
);
Expand Down
Loading
Loading