Skip to content

rollback fast xml parser#1741

Merged
gugu merged 1 commit into
mainfrom
rollback-fast-xml-parser
Apr 27, 2026
Merged

rollback fast xml parser#1741
gugu merged 1 commit into
mainfrom
rollback-fast-xml-parser

Conversation

@gugu
Copy link
Copy Markdown
Contributor

@gugu gugu commented Apr 27, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 27, 2026 12:27
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

Warning

Rate limit exceeded

@gugu has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 52 minutes and 42 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1590185d-d1d3-45e6-ab19-1f502e7f1c28

📥 Commits

Reviewing files that changed from the base of the PR and between bfcf7d7 and cdf3cac.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • backend/package.json
  • package.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rollback-fast-xml-parser

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gugu gugu enabled auto-merge (squash) April 27, 2026 12:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the workspace-wide pnpm.overrides constraint for fast-xml-parser (allowing versions <5.7.0 again) and updates AWS SDK dependency versions in the backend, with the corresponding lockfile regeneration.

Changes:

  • Remove the fast-xml-parser@<5.7.0 override from the root package.json.
  • Bump several @aws-sdk/* dependencies in backend/package.json to ^3.1037.0.
  • Regenerate pnpm-lock.yaml, introducing fast-xml-parser@5.5.8 alongside existing 5.7.1 and updating multiple AWS/Smithy entries.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
pnpm-lock.yaml Reflects override removal and dependency graph updates; currently contains an AWS SDK peer mismatch for DynamoDB packages.
package.json Removes the fast-xml-parser override under pnpm.overrides.
backend/package.json Upgrades AWS SDK packages to ^3.1037.0, which currently conflicts with resolved DynamoDB client version in the lockfile.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread backend/package.json
"@aws-sdk/client-s3": "^3.1011.0",
"@aws-sdk/lib-dynamodb": "^3.1011.0",
"@aws-sdk/s3-request-presigner": "^3.1011.0",
"@aws-sdk/client-bedrock-runtime": "^3.1037.0",
Copy link

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aws-sdk/lib-dynamodb is bumped to ^3.1037.0, but the lockfile resolves it with @aws-sdk/client-dynamodb@3.1032.0 (peer for lib-dynamodb@3.1037.0 is ^3.1037.0). This peer mismatch can lead to warnings or subtle runtime/type incompatibilities. Align the workspace by upgrading @aws-sdk/client-dynamodb to a compatible version (and/or bump the shared-code package’s AWS SDK versions) so lib-dynamodb and client-dynamodb are on the same minor/patch line.

Suggested change
"@aws-sdk/client-bedrock-runtime": "^3.1037.0",
"@aws-sdk/client-bedrock-runtime": "^3.1037.0",
"@aws-sdk/client-dynamodb": "^3.1037.0",

Copilot uses AI. Check for mistakes.
Comment thread backend/package.json
Comment on lines +28 to +31
"@aws-sdk/client-bedrock-runtime": "^3.1037.0",
"@aws-sdk/client-s3": "^3.1037.0",
"@aws-sdk/lib-dynamodb": "^3.1037.0",
"@aws-sdk/s3-request-presigner": "^3.1037.0",
Copy link

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title indicates this is a rollback of fast-xml-parser, but this change set also upgrades several AWS SDK packages (and triggers a large pnpm-lock.yaml churn). If the AWS SDK updates are not intentional, consider reverting them and regenerating the lockfile to keep this PR focused; otherwise, please update the PR title/description to reflect the broader dependency upgrade.

Copilot uses AI. Check for mistakes.
Comment thread pnpm-lock.yaml
Comment on lines 49 to +51
'@aws-sdk/lib-dynamodb':
specifier: ^3.1011.0
version: 3.1032.0(@aws-sdk/client-dynamodb@3.1032.0)
specifier: ^3.1037.0
version: 3.1037.0(@aws-sdk/client-dynamodb@3.1032.0)
Copy link

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lockfile shows @aws-sdk/lib-dynamodb@3.1037.0 being installed with @aws-sdk/client-dynamodb@3.1032.0 (version: 3.1037.0(@aws-sdk/client-dynamodb@3.1032.0)). Since lib-dynamodb@3.1037.0 declares a peer dependency on @aws-sdk/client-dynamodb ^3.1037.0, this resolution is inconsistent. Update dependencies so pnpm resolves a compatible client-dynamodb version (or keep lib-dynamodb at a version compatible with 3.1032.0).

Copilot uses AI. Check for mistakes.
@gugu gugu merged commit 1dac917 into main Apr 27, 2026
22 of 23 checks passed
@gugu gugu deleted the rollback-fast-xml-parser branch April 27, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants