Skip to content

table view: fix link clicks on table rows and change icon on Settings button #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lyubov-voloshko merged 3 commits into from
Apr 30, 2026
Merged

table view: fix link clicks on table rows and change icon on Settings button #1747

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bd5013
table view: fix link clicks on table rows and change icon on Settings…
lyubov-voloshko Apr 29, 2026
b29e8ca
Merge branch 'main' into mini-fixes
lyubov-voloshko Apr 29, 2026
26c289c
Merge branch 'main' into mini-fixes
lyubov-voloshko Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions frontend/src/app/components/dashboard/db-table-view/db-table-view.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ <h2 class="mat-h2 table-name">{{ displayName }}</h2>
angulartics2On="click"
angularticsAction="Dashboard: settings dropdown is clicked"
(click)="posthog.capture('Dashboard: settings dropdown is clicked')">
<mat-icon>more_vert</mat-icon>
<mat-icon fontSet="material-symbols-outlined">settings</mat-icon>
</button>
<mat-menu #settingsMenu="matMenu">
<a mat-menu-item *ngIf="tableData"
Expand Down Expand Up @@ -352,7 +352,7 @@ <h2 class="mat-h2 table-name">{{ displayName }}</h2>
angulartics2On="click"
angularticsAction="Dashboard: edit row is clicked"
matTooltip="Edit row"
(click)="stashUrlParams(); posthog.capture('Dashboard: edit row is clicked')">
(click)="$event.stopPropagation(); stashUrlParams(); posthog.capture('Dashboard: edit row is clicked')">
<mat-icon fontSet="material-symbols-outlined">create</mat-icon>
</a>
<a mat-icon-button *ngIf="canAddRow()"
Expand All @@ -365,7 +365,7 @@ <h2 class="mat-h2 table-name">{{ displayName }}</h2>
angulartics2On="click"
angularticsAction="Dashboard: duplicate row is clicked"
matTooltip="Duplicate row"
(click)="stashUrlParams(); posthog.capture('Dashboard: duplicate row is clicked')">
(click)="$event.stopPropagation(); stashUrlParams(); posthog.capture('Dashboard: duplicate row is clicked')">
<mat-icon fontSet="material-symbols-outlined">difference</mat-icon>
</a>
<button type="button" mat-icon-button *ngIf="canDeleteRow() && tableData.canDelete"
Expand Down
Loading