fix: update test to parse response body for encoding error message#1758
Conversation
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the Binary widget e2e test to properly parse the HTTP response body as JSON before asserting on the error message, replacing a direct substring check against the raw response text. The assertion validates the same ChangesBinary Widget Encoding Test Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the Binary widget E2E test to assert the server’s “unsupported encoding” error message by parsing the JSON response body (instead of matching against the raw response text), making the assertion resilient to JSON string escaping/encoding.
Changes:
- Parse the 400-response payload as JSON in the “invalid encoding value” test case.
- Assert against
body.message(decoded string) rather than searching withincreateResponse.text.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary by CodeRabbit