Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection string improvements #1766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Connection string improvements #1766
Changes from all commits
076a6a148a316575db534699a25b066e551b12d9eff154446efa81edFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: rocket-admin/rocketadmin
Length of output: 805
🏁 Script executed:
Repository: rocket-admin/rocketadmin
Length of output: 1723
🏁 Script executed:
Repository: rocket-admin/rocketadmin
Length of output: 461
🏁 Script executed:
Repository: rocket-admin/rocketadmin
Length of output: 1298
🏁 Script executed:
Repository: rocket-admin/rocketadmin
Length of output: 498
🏁 Script executed:
Repository: rocket-admin/rocketadmin
Length of output: 350
🏁 Script executed:
Repository: rocket-admin/rocketadmin
Length of output: 1796
Add explicit return type and remove unused parameter.
The
_inputparameter is never used in the method body (the method relies onthis.connectionStringinstead). Remove the unused parameter and add an explicitvoidreturn type.Proposed fix
Per coding guidelines: "Always add type annotations to function parameters and return types in TypeScript" and "Avoid any types."
📝 Committable suggestion
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set
fieldsOverriddenonly when an autofilled field was actually cleared.fieldsOverriddenis currently set totrueon every field change, even if no autofilled field existed. That can trigger override UI in manual-entry flows.Proposed fix
clearAutoFilledField(field: string): void { - this.autoFilledFields = new Set(this.autoFilledFields); - this.autoFilledFields.delete(field); - this.fieldsOverridden = true; + const hadField = this.autoFilledFields.has(field); + this.autoFilledFields = new Set(this.autoFilledFields); + this.autoFilledFields.delete(field); + if (hadField) { + this.fieldsOverridden = true; + } }🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.