Skip to content

feat: pass threadId across schema generation requests for conversatio… #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lyubov-voloshko merged 1 commit into from
May 14, 2026
+8 −3
Merged

feat: pass threadId across schema generation requests for conversatio… #1774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion frontend/src/app/components/edit-database-schema/edit-database-schema.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ export class EditDatabaseSchemaComponent implements OnInit, AfterViewInit {
protected applied = signal(false);
protected diagramZoom = signal(1);
protected initialDiagramLoading = signal(false);
private _threadId: string | undefined;

protected pendingBatch = computed(() => {
const msgs = this.messages();
Expand Down Expand Up @@ -98,7 +99,10 @@ export class EditDatabaseSchemaComponent implements OnInit, AfterViewInit {
this.submitting.set(true);

try {
const result = await this._tableSchema.generateSchemaChange(this.connectionID, prompt);
const result = await this._tableSchema.generateSchemaChange(this.connectionID, prompt, this._threadId);
if (result.threadId) {
this._threadId = result.threadId;
}
if (result && result.changes.length > 0) {
const summary = result.changes.map(c => `**${c.changeType}** \`${c.targetTableName}\`${c.aiSummary ? ' — ' + c.aiSummary : ''}`).join('\n');
this.messages.update(msgs => [...msgs, {
Expand Down
5 changes: 3 additions & 2 deletions frontend/src/app/services/table-schema.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export interface SchemaChangeResponse {
export interface SchemaChangeBatchResponse {
batchId: string;
changes: SchemaChangeResponse[];
threadId?: string | null;
}

@Injectable({
Expand All @@ -43,8 +44,8 @@ export interface SchemaChangeBatchResponse {
export class TableSchemaService {
private _api = inject(ApiService);

async generateSchemaChange(connectionId: string, userPrompt: string): Promise<SchemaChangeBatchResponse> {
return this._fetchOrThrow<SchemaChangeBatchResponse>(`/table-schema/${connectionId}/generate`, { userPrompt });
async generateSchemaChange(connectionId: string, userPrompt: string, threadId?: string): Promise<SchemaChangeBatchResponse> {
return this._fetchOrThrow<SchemaChangeBatchResponse>(`/table-schema/${connectionId}/generate`, { userPrompt, threadId });
}

async approveBatch(batchId: string, confirmedDestructive?: boolean): Promise<SchemaChangeBatchResponse> {
Expand Down
Loading