Fix fallbackEc initialization in ec-manager

thomaspanf · thomaspanf · commit 16d13218da68 · 2025-06-03T09:43:05.000-04:00
diff --git a/shared/services/ec-manager.go b/shared/services/ec-manager.go
@@ -77,15 +77,18 @@ func NewExecutionClientManager(cfg *config.RocketPoolConfig) (*ExecutionClientMa
 		}
 	}
 
-	return &ExecutionClientManager{
+	out := &ExecutionClientManager{
 		primaryEcUrl:  primaryEcUrl,
 		fallbackEcUrl: fallbackEcUrl,
 		primaryEc:     &ethClient{primaryEc},
-		fallbackEc:    &ethClient{fallbackEc},
 		logger:        log.NewColorLogger(color.FgYellow),
 		primaryReady:  true,
 		fallbackReady: fallbackEc != nil,
-	}, nil
+	}
+	if fallbackEc != nil {
+		out.fallbackEc = &ethClient{fallbackEc}
+	}
+	return out, nil
 
 }
 

Original file line number	Diff line number	Diff line change
`@@ -77,15 +77,18 @@ func NewExecutionClientManager(cfg config.RocketPoolConfig) (ExecutionClientMa`
`77`	`77`	`}`
`78`	`78`	`}`
`79`	`79`
`80`		`- return &ExecutionClientManager{`
	`80`	`+ out := &ExecutionClientManager{`
`81`	`81`	`primaryEcUrl: primaryEcUrl,`
`82`	`82`	`fallbackEcUrl: fallbackEcUrl,`
`83`	`83`	`primaryEc: &ethClient{primaryEc},`
`84`		`- fallbackEc: &ethClient{fallbackEc},`
`85`	`84`	`logger: log.NewColorLogger(color.FgYellow),`
`86`	`85`	`primaryReady: true,`
`87`	`86`	`fallbackReady: fallbackEc != nil,`
`88`		`- }, nil`
	`87`	`+ }`
	`88`	`+ if fallbackEc != nil {`
	`89`	`+ out.fallbackEc = &ethClient{fallbackEc}`
	`90`	`+ }`
	`91`	`+ return out, nil`
`89`	`92`
`90`	`93`	`}`
`91`	`94`