WIP add propose allow listed controller addresses

Author: thomaspanf

bindings/settings/protocol/network.go

@@ -32,6 +32,7 @@ const (
 	NetworkPenaltyThresholdSettingPath     string = "network.penalty.threshold"
 	NetworkPenaltyPerRateSettingPath       string = "network.penalty.per.rate"
 	SubmitRewardsEnabledSettingPath        string = "network.submit.rewards.enabled"
+	NetworkAllowListedControllersPath      string = "network.allow.listed.controllers"
 )
 
 // The threshold of trusted nodes that must reach consensus on oracle data to commit it

rocketpool-cli/pdao/commands.go

@@ -18,6 +18,7 @@ const (
 	unboundedPercentUsage string = "specify a percentage that can go over 100% (e.g., '1.5' for 150%)"
 	uintUsage             string = "specify an integer (e.g., '50')"
 	durationUsage         string = "specify a duration using hours, minutes, and seconds (e.g., '20m' or '72h0m0s')"
+	addressListUsage      string = "specify a list of one or more addresses separated by commas (e.g., '0x1a2b3c4d5e6f7890abcdef1234567890abcdef12,0xabcdefabcdefabcdefabcdefabcdefabcdefabcd')"
 )
 
 // Register commands
@@ -1549,6 +1550,34 @@ func RegisterCommands(app *cli.App, name string, aliases []string) {
 
 										},
 									},
+
+									{
+										Name:      "allow-listed-controllers",
+										Aliases:   []string{"alc"},
+										Usage:     fmt.Sprintf("Propose updating the %s setting; %s", protocol.NetworkAllowListedControllersPath, addressListUsage),
+										UsageText: "rocketpool pdao propose setting network allow-listed-controllers value",
+										Flags: []cli.Flag{
+											cli.BoolFlag{
+												Name:  "yes, y",
+												Usage: "Automatically confirm all interactive questions",
+											},
+										},
+										Action: func(c *cli.Context) error {
+
+											// Validate args
+											if err := cliutils.ValidateArgCount(c, 1); err != nil {
+												return err
+											}
+											value, err := cliutils.ValidateAddresses("value", c.Args().Get(0))
+											if err != nil {
+												return err
+											}
+
+											// Run
+											return proposeSettingNetworkAllowListedControllers(c, value)
+
+										},
+									},
 								},
 							},
 

rocketpool-cli/pdao/propose-settings.go

@@ -3,8 +3,10 @@ package pdao
 import (
 	"fmt"
 	"math/big"
+	"strings"
 	"time"
 
+	"github.com/ethereum/go-ethereum/common"
 	"github.com/rocket-pool/smartnode/bindings/settings/protocol"
 	"github.com/rocket-pool/smartnode/bindings/utils/eth"
 	"github.com/urfave/cli"
@@ -300,6 +302,15 @@ func proposeSettingSecurityProposalActionTime(c *cli.Context, value time.Duratio
 	return proposeSetting(c, protocol.SecuritySettingsContractName, protocol.SecurityProposalActionTimeSettingPath, trueValue)
 }
 
+func proposeSettingNetworkAllowListedControllers(c *cli.Context, value []common.Address) error {
+	strs := make([]string, len(value))
+	for i, addr := range value {
+		strs[i] = addr.Hex()
+	}
+	trueValue := strings.Join(strs, "")
+	return proposeSetting(c, protocol.NetworkSettingsContractName, protocol.NetworkAllowListedControllersPath, trueValue)
+}
+
 // Master general proposal function
 func proposeSetting(c *cli.Context, contract string, setting string, value string) error {
 	// Get RP client