Fix govet (unreachable wg)

Author: jshufro

.golangci.yml

@@ -2,6 +2,7 @@ version: "2"
 linters:
   default: none
   enable:
+    - govet
     - ineffassign
     - unused
     - staticcheck

rocketpool/watchtower/watchtower.go

@@ -7,7 +7,6 @@ import (
 	"math/rand"
 	"net/http"
 	"os"
-	"sync"
 	"time"
 
 	"github.com/ethereum/go-ethereum/accounts/abi/bind"
@@ -184,11 +183,7 @@ func run(c *cli.Command) error {
 	intervalDelta := maxTasksInterval - minTasksInterval
 	secondsDelta := intervalDelta.Seconds()
 
-	// Wait group to handle the various threads
-	wg := new(sync.WaitGroup)
-	wg.Add(2)
-
-	// Run task loop
+	// Run task loop forever
 	go func() {
 		for {
 			// Randomize the next interval
@@ -336,7 +331,6 @@ func run(c *cli.Command) error {
 
 			time.Sleep(interval)
 		}
-		wg.Done()
 	}()
 
 	// Run metrics loop
@@ -345,11 +339,8 @@ func run(c *cli.Command) error {
 		if err != nil {
 			errorLog.Println(err)
 		}
-		wg.Done()
 	}()
 
-	// Wait for both threads to stop
-	wg.Wait()
 	return nil
 }
 

shared/services/connectivity/check-port-connectivity.go

@@ -178,7 +178,7 @@ func getPublicIP() (string, error) {
 // isPortReachableNATReflection attempts a TCP connection to host:port and returns true if
 // the connection succeeds within portCheckTimeout.
 func isPortReachableNATReflection(host string, port uint16) bool {
-	address := fmt.Sprintf("%s:%d", host, port)
+	address := net.JoinHostPort(host, strconv.FormatUint(uint64(port), 10))
 	conn, err := net.DialTimeout("tcp", address, portCheckTimeout)
 	if err != nil {
 		return false