Fix ineffassign

Author: jshufro

.golangci.yml

@@ -1,7 +1,8 @@
 version: "2"
 linters:
-  default: none 
+  default: none
   enable:
+    - ineffassign
     - unused
     - staticcheck
   settings:

rocketpool-cli/node/utils.go

@@ -177,7 +177,6 @@ func promptTimezone() string {
 	// Prompt for country
 	country := ""
 	for {
-		timezone = ""
 		country = prompt.Prompt("Please enter a country / continent from the list above:", "^.+$", "Please enter a country / continent from the list above:")
 
 		exists := slices.Contains(countryNames, country)
@@ -231,7 +230,6 @@ func promptTimezone() string {
 	// Prompt for region
 	region := ""
 	for {
-		timezone = ""
 		region = prompt.Prompt("Please enter a region from the list above:", "^.+$", "Please enter a region from the list above:")
 
 		exists := slices.Contains(regionNames, region)

rocketpool/watchtower/submit-rpl-price.go

@@ -381,7 +381,7 @@ func (t *submitRplPrice) run(state *state.NetworkState) error {
 	var lastSubmissionSlotTimestamp uint64
 	// Check if the node has submitted prices for the latest block
 	if lastSubmissionBlock != 0 {
-		lastSubmissionEvent := network.PriceUpdatedEvent{}
+		var lastSubmissionEvent network.PriceUpdatedEvent
 		eventFound, lastSubmissionEvent, err = network.GetPriceUpdatedEvent(t.rp, lastSubmissionBlock, nil)
 		if err != nil {
 			t.log.Printlnf("Error getting price submission event for block %d", lastSubmissionBlock)