Skip to content

Add go.work, go.work.sum, and turn smartnode top level packages into modules#789

Merged
0xfornax merged 22 commits into
rocket-pool:masterfrom
jshufro:jms/monorepo
May 19, 2025
Merged

Add go.work, go.work.sum, and turn smartnode top level packages into modules#789
0xfornax merged 22 commits into
rocket-pool:masterfrom
jshufro:jms/monorepo

Conversation

@jshufro
Copy link
Copy Markdown
Contributor

@jshufro jshufro commented May 6, 2025

The last piece in removing smartnode-install: porting the build to this repository.

The make release command builds all artifacts for a release, creates and tags docker containers, and creates and tags a docker manifest. I have not added docker push commands, as I think those should be executed cautiously, but we can add them if we want.

make release currently will make a directory structure a la:

build
├── 1.15.6
│   ├── cli
│   │   ├── rocketpool-cli-darwin-amd64
│   │   ├── rocketpool-cli-darwin-arm64
│   │   ├── rocketpool-cli-linux-amd64
│   │   └── rocketpool-cli-linux-arm64
│   └── daemon
│       ├── rocketpool-daemon-linux-amd64
│       └── rocketpool-daemon-linux-arm64
├── rocketpool-cli -> /home/jacob/rocketpool/smartnode/build/1.15.6/cli/rocketpool-cli-linux-amd64
└── rocketpool-daemon -> /home/jacob/rocketpool/smartnode/build/1.15.6/daemon/rocketpool-daemon-linux-amd64

but we can flatten it to behave more like smartnode-install if we want. This just feels more organized.

Comment thread Makefile Outdated
@jshufro jshufro marked this pull request as draft May 9, 2025 18:17
@jshufro jshufro force-pushed the jms/monorepo branch 3 times, most recently from 597d853 to c1c0369 Compare May 16, 2025 21:24
@jshufro jshufro marked this pull request as ready for review May 16, 2025 21:36
Comment thread README.md Outdated
@0xfornax 0xfornax merged commit fc403d8 into rocket-pool:master May 19, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants