Fix commands that require escalation#793
Merged
Merged
Conversation
0xfornax
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://go.dev/play/p/WbgPaKbHJdE demonstrates the need/safety of shellescape
Basically, we want to delete the getEscalationCmd to make sure that when root is required, it is used 'correctly'.
'Correctly' here means in a statement that looks like
sudo bash -c 'rm -rf .rocketpool/validators'/*, otherwise the *-expansion fails ifvalidatorsis not readable by the non-escalated user. To make sure we don't have misuse, we delete the getEscalationCmd, and add a function called readOutputSudo which does the same thing as readOutput, but first gets the appropriate escalation command (sudo or doas), and safely wraps the command in asudo/doas bash -c '%s'