Skip to content

Fix sending custom tokens without 18 decimals#796

Merged
0xfornax merged 3 commits into
masterfrom
fix-sending-custom-tokens
May 14, 2025
Merged

Fix sending custom tokens without 18 decimals#796
0xfornax merged 3 commits into
masterfrom
fix-sending-custom-tokens

Conversation

@0xfornax
Copy link
Copy Markdown
Member

Closes #795

@0xfornax 0xfornax requested a review from thomaspanf May 12, 2025 20:15
Comment thread rocketpool/api/node/send.go Outdated
Comment thread shared/types/api/node.go
Status string `json:"status"`
Error string `json:"error"`
Balance *big.Int `json:"balance"`
Balance float64 `json:"balance"`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really switch to something like this at some point:
https://pkg.go.dev/github.com/shopspring/decimal

@0xfornax 0xfornax merged commit b36f537 into master May 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node send assumes 18 decimals

3 participants