Change install commands to use local assets instead of downloading from github#799
Merged
Conversation
This was referenced May 13, 2025
0xfornax
reviewed
May 13, 2025
0xfornax
reviewed
May 14, 2025
0xfornax
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply absorbs the smartnode-install shell scripts and assets into smartnode proper.
The first commit copies those files in verbatim. No changes.
Start reviewing from the second commit.
As part of this, we deprecate
--versionarguments forrocketpool s installet al, as these scripts are now tied to specific binaries. Installing old versions in the future will only be possible with the correspondingrocketpool-cli.For now, smartnode-install is still required, but the scripts moved in this PR are superceded and will be deleted in rocket-pool/smartnode-install#145 ... At some point in the future, smartnode-install will be fully deprecated (or, at least, replaced with a binary that warns people where to find the new binaries).
Docs updates to merge after: rocket-pool/docs.rocketpool.net#116