Add Pushover notification support to alerting configuration#819
Conversation
| send_resolved: false | ||
| {{- end }} | ||
|
|
||
| {{- if .PushoverToken.Value .PushoverUserKey.Value }} |
There was a problem hiding this comment.
Was it intentional to repeat this code here?
There was a problem hiding this comment.
the idea was to mimic the same block as with discord, but I see that I copied pasted and forgot to add send_resolved: false. Now fixed, thanks for catching it.
|
@0xfornax I now tested it locally on a development environment, fixing and improving some behaviors. This should be ready. |
| pushover_configs: | ||
| - token: "{{ .PushoverToken.Value }}" | ||
| user_key: "{{ .PushoverUserKey.Value }}" | ||
| priority: {{ `'{{ if eq .CommonLabels.severity "critical" }}2{{ else if eq .CommonLabels.severity "warning" }}1{{ else }}0{{ end }}'` }} |
There was a problem hiding this comment.
just to open a discussion about the values vis-a-vis alerts..
a priority of 1 for warning messages means that the user will get an override of quiet hours and get a notification for warning messages. Now, most alerts (e.g. OSUpdates or RPUpdates) are sending warning, with little sending info. Perhaps we should review the severities of the rules too in a different PR?
Any refactors in flight shouldn't impact this much. You already got in just after we moved all these files out of smartnode-install, which would have been the bigger issue. SUPER happy to see more alertmanager channels supported. If you feel like contributing more, see this poll: I'd support a GMC grant to cover these, if you are interested in that. |
|
@jshufro sure thing, happy to. |
3 participants
Adds configuration parameters to TUI to configure Pushover notifications. These can be used together with Discord notifications.
closes #818