Skip to content

Single module monorepo#834

Merged
0xfornax merged 5 commits into
rocket-pool:masterfrom
jshufro:jms/deps
May 28, 2025
Merged

Single module monorepo#834
0xfornax merged 5 commits into
rocket-pool:masterfrom
jshufro:jms/deps

Conversation

@jshufro

@jshufro jshufro commented May 23, 2025

Copy link
Copy Markdown
Contributor

At some point I soured on go.work. I think there's a variety of reasons, but mainly, our code needs simply aren't complicated enough to need to maintain separate dependency lists.

Also, there is this:

It is generally inadvisable to commit go.work files into version control systems, for two reasons:

A checked-in go.work file might override a developer’s own go.work file from a parent directory, causing confusion when their use directives don’t apply.
A checked-in go.work file may cause a continuous integration (CI) system to select and thus test the wrong versions of a module’s dependencies. CI systems should generally not be allowed to use the go.work file so that they can test the behavior of the module as it would be used when required by other modules, where a go.work file within the module has no effect.

@jshufro jshufro marked this pull request as draft May 23, 2025 17:51
@jshufro jshufro force-pushed the jms/deps branch 10 times, most recently from cff3319 to f43aae2 Compare May 23, 2025 19:35
@jshufro jshufro marked this pull request as ready for review May 23, 2025 19:43

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building natively helps cover cases where cross compilation fails
Building in docker is largely just done to ensure that the docker build itself doesn't break.

@0xfornax 0xfornax merged commit 2e85b17 into rocket-pool:master May 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants