Skip to content

Commit 199ee56

Browse files
kwit75claude
authored andcommitted
chore: pin pnpm version via packageManager field (#623)
* chore: pin pnpm version via packageManager field Adds 'packageManager': 'pnpm@10.33.0' to root package.json so that contributors using corepack get the same pnpm version as CI (.github/workflows/_build.yaml uses pnpm/action-setup@v4 with version 10). Also bumps the engines.pnpm range from '>=8.0.0' to '>=10.0.0' for consistency. The previous loose constraint allowed contributors to regenerate pnpm-lock.yaml with pnpm 8 or 9, which strips lockfile-v9+ fields like 'libc' from native package entries — exactly what happened in #621 and required #622 as a follow-up cleanup. This is a recurrence-prevention measure following that incident. * ci: pin pnpm to 10.33.0 in _build.yaml to match packageManager Addresses CodeRabbit feedback on this PR — packageManager pins to 10.33.0 exactly, but CI was floating on 'version: 10' which allowed patch-level drift. Now both local (via corepack) and CI use the same exact pnpm version. --------- Co-authored-by: kwit75 <noreply@anthropic.com>
1 parent e367287 commit 199ee56

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

.github/workflows/_build.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ jobs:
7676
- name: Set up pnpm
7777
uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4
7878
with:
79-
version: 10
79+
version: 10.33.0
8080
- name: Set up vcpkg
8181
run: ${{ matrix.builder_cmd }} vcpkg:submodule-build
8282
- name: Set up vcpkg nuget / Linux/macOS

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,10 @@
3434
"scripts": {
3535
"prepare": "lefthook install --force"
3636
},
37+
"packageManager": "pnpm@10.33.0",
3738
"engines": {
3839
"node": ">=18.0.0",
39-
"pnpm": ">=8.0.0"
40+
"pnpm": ">=10.0.0"
4041
},
4142
"pnpm": {
4243
"peerDependencyRules": {

0 commit comments

Comments
 (0)