fix(nodes): improve error handling in remote node execution (#565)

* feat(vscode): improve stop button feedback in Pipeline Observability screen

Handle TASK_STATE.STOPPING in the control button to show "Stopping..."
with a disabled state and distinct orange styling, preventing duplicate
clicks and giving immediate visual feedback during pipeline shutdown.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(nodes): improve error handling in remote node execution

Replace fragile string-based error origin detection with proper type
checking (isinstance + error code comparison). Always send error signals
to the remote side to prevent hanging connections. Narrow exception
catch from BaseException to Exception to avoid intercepting
KeyboardInterrupt and SystemExit.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: charliegillet

nodes/src/nodes/remote/base/IInstance.py

@@ -190,13 +190,15 @@ def callRemote(self, lane: str, data: None | str | bytes | dict | list = None):
                     # Send the success signal to the remote pipeline
                     self._send('error', APERR().toDict())
 
-                except BaseException as e:
-                    # TODO: Improve local/remote error handling
-                    if (msg := str(e)) and 'RemoteException:' not in msg:
-                        # Send the error signal to the remote pipeline
-                        self._send('error', APERR(Ec.RemoteException, msg).toDict())
+                except Exception as e:
+                    # Determine whether this error originated from the remote side.
+                    # If so, propagate the original error code; otherwise wrap it as
+                    # a new RemoteException so the remote side sees what went wrong.
+                    if isinstance(e, APERR) and e.ec == Ec.RemoteException:
+                        self._send('error', e.toDict())
+                    else:
+                        self._send('error', APERR(Ec.RemoteException, str(e)).toDict())
 
-                    # Re-raise the exception
                     raise
 
     def callLocal(self, lane: str, data):

nodes/src/nodes/remote/server/IInstance.py

@@ -59,13 +59,15 @@ def handleWebSocket(self, webSocket: WebSocket):
                 # Send the success signal to the remote pipeline
                 self._send('error', APERR().toDict())
 
-            except BaseException as e:
-                # TODO: Improve local/remote error handling
-                if (msg := str(e)) and 'RemoteException:' not in msg:
-                    # Send the error signal to the remote pipeline
-                    self._send('error', APERR(Ec.RemoteException, msg).toDict())
+            except Exception as e:
+                # Determine whether this error originated from the remote side.
+                # If so, propagate the original error code; otherwise wrap it as
+                # a new RemoteException so the remote side sees what went wrong.
+                if isinstance(e, APERR) and e.ec == Ec.RemoteException:
+                    self._send('error', e.toDict())
+                else:
+                    self._send('error', APERR(Ec.RemoteException, str(e)).toDict())
 
-                # Re-raise the exception
                 raise
 
     def writeText(self, text: str):