fix(vscode): repoint example links to repo pipelines (#1422)#1435
fix(vscode): repoint example links to repo pipelines (#1422)#1435kairavb wants to merge 2 commits into
Conversation
Replace broken docs.rocketride.org example URLs with working GitHub links to examples/*.pipe. Align issue template docs URL to .org domain. Fixes rocketride-org#1422 Co-authored-by: Cursor <cursoragent@cursor.com>
🤖 Internal: Discord sync markerAuto-managed by the Discord notification workflow. Stores the linked Discord message ID. Do not edit or delete. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR updates documentation links in the VS Code docs and issue template, repointing example pipeline links to GitHub-hosted ChangesDocumentation link fixes
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dsapandora
left a comment
There was a problem hiding this comment.
Nice, this is a satisfying little fix — dead links replaced with links to the actual .pipe files people can read right away instead of a 404'd docs page. Good call pointing at real examples (rag-pipeline, document-processor, agent-llamaindex) instead of the vague ones that used to be referenced.
One thing worth a quick gut-check before merging: all six new example links are hardcoded to blob/develop/.... That's fine today, but if develop ever gets rebased/renamed or those files move, the links go stale again — which is exactly the problem this PR is fixing. Not a blocker, just something to keep in mind (a raw.githubusercontent link or tagging the URL to a stable release branch would age better, but browsable blob links are more useful for someone clicking through in the marketplace README, so I get the tradeoff).
Also double check that examples/rag-pipeline.pipe, examples/document-processor.pipe, and examples/agent-llamaindex.pipe actually exist at those exact paths on develop — a typo here would be an easy miss since it's just three markdown files and nothing will fail CI on a bad link.
The docs.rocketride.ai → .org swap in the issue template looks like a straightforward alignment fix, no concerns there. Overall this is a clean, well-scoped docs patch — good to go once the links are confirmed live.
| - **SDKs for TypeScript, Python & MCP** - Embed pipelines in your apps or expose them as tools for AI assistants. | ||
|
|
||
| Need inspiration? Check out our [example pipelines](https://docs.rocketride.org/): | ||
| Need inspiration? Check out our [example pipelines](https://github.com/rocketride-org/rocketride-server/tree/develop/examples): |
There was a problem hiding this comment.
This needs to point to the awesome-rocketride repository
Per review feedback on rocketride-org#1435.
|
Confirmed all three .pipe files exist at those paths on develop and the links resolve (200). Kept blob/develop links for the individual templates since they’re directly browsable from the marketplace README Updated to point at awesome-rocketride as requested. Thanks! |
|
Hey @kairavb, sorry, this one's on us and not on you. You read the issue right, you got here first, and when Josh asked you to repoint at awesome-rocketride you turned it around the same day. Meanwhile we settled internally on a slightly different shape for that section: drop the bullet list entirely and just link awesome-rocketride, so the catalog lives in one place and the extension README stops going stale every time an example moves. That's a call we made after you'd already done the work. It went in as #1448 and is on develop now, which is why this shows as conflicting. Different from what #1422 proposed, and different from this PR, but not because anything here was wrong. One hunk of yours we didn't take: the Closing this one. There's a lot left unclaimed in the #1402 to #1432 batch if you're up for another. |
Replace broken docs.rocketride.org example URLs with working GitHub links to examples/*.pipe. Align issue template docs URL to .org domain.
Summary
Type
Testing
Checklist
Linked Issue
Fixes #1422
Summary by CodeRabbit
.pipefiles on thedevelopbranch: RAG Pipeline, Document Processor, and LlamaIndex Agent.