feat(nodes): add batch processing node for large dataset pipelines#552
feat(nodes): add batch processing node for large dataset pipelines#552charliegillet wants to merge 1 commit into
Conversation
…screen Handle TASK_STATE.STOPPING in the control button to show "Stopping..." with a disabled state and distinct orange styling, preventing duplicate clicks and giving immediate visual feedback during pipeline shutdown. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
charliegillet
requested review from
Rod-Christensen,
jmaionchi and
stepmikhaylov
as code owners
📝 WalkthroughWalkthroughAdded explicit handling for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/vscode/src/providers/views/PageStatus/styles.css`:
- Around line 309-313: The stopping-btn state still receives the interactive
hover styles from .action-btn:hover; update the CSS so .action-btn.stopping-btn
cancels hover effects by overriding the hover selector (e.g. add a
.action-btn.stopping-btn:hover rule) and explicitly disable interaction
(pointer-events: none or equivalent), and reset transform/box-shadow/transition
so the “Stopping...” control no longer animates or appears interactive; target
.action-btn.stopping-btn and .action-btn.stopping-btn:hover to implement these
overrides.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 0a2c2b6b-979e-425b-82dd-d6ec68710b5f
📒 Files selected for processing (2)
apps/vscode/src/providers/views/PageStatus/PageStatus.tsxapps/vscode/src/providers/views/PageStatus/styles.css
| .action-btn.stopping-btn { | ||
| background: var(--vscode-charts-orange); | ||
| color: white; | ||
| cursor: not-allowed; | ||
| } |
There was a problem hiding this comment.
Prevent hover animation on disabled “Stopping...” control.
Line 309-Line 313 defines a disabled visual state, but .action-btn:hover still applies transform/shadow. This makes a disabled control look interactive.
🎯 Proposed CSS fix
.action-btn.stopping-btn {
background: var(--vscode-charts-orange);
color: white;
cursor: not-allowed;
}
+
+.action-btn.disabled:hover,
+.action-btn.stopping-btn:hover {
+ transform: none;
+ box-shadow: none;
+ background: var(--vscode-charts-orange);
+}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| .action-btn.stopping-btn { | |
| background: var(--vscode-charts-orange); | |
| color: white; | |
| cursor: not-allowed; | |
| } | |
| .action-btn.stopping-btn { | |
| background: var(--vscode-charts-orange); | |
| color: white; | |
| cursor: not-allowed; | |
| } | |
| .action-btn.disabled:hover, | |
| .action-btn.stopping-btn:hover { | |
| transform: none; | |
| box-shadow: none; | |
| background: var(--vscode-charts-orange); | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@apps/vscode/src/providers/views/PageStatus/styles.css` around lines 309 -
313, The stopping-btn state still receives the interactive hover styles from
.action-btn:hover; update the CSS so .action-btn.stopping-btn cancels hover
effects by overriding the hover selector (e.g. add a
.action-btn.stopping-btn:hover rule) and explicitly disable interaction
(pointer-events: none or equivalent), and reset transform/box-shadow/transition
so the “Stopping...” control no longer animates or appears interactive; target
.action-btn.stopping-btn and .action-btn.stopping-btn:hover to implement these
overrides.
|
Closing — PR shipped incorrect code (PageStatus change instead of the claimed feature). The actual feature code landed in a different PR. |
1 participant
Summary
TASK_STATE.STOPPINGhandling to the pipeline status control button in the VS Code extensionType
Bug Fix (UX)
Why this bug happens in this codebase
The
getControlButton()function inPageStatus.tsxhandlesTASK_STATE.RUNNINGandTASK_STATE.INITIALIZINGbut did not handleTASK_STATE.STOPPING. When a pipeline entered the stopping state, the button fell through to the default case and showed a disabled "Run" button — confusing because it gave no indication that a stop was in progress.The codebase already defines
TASK_STATE.STOPPINGin its state enum and theStatusHeadercomponent already renders an orange "Stopping" indicator dot for this state, but the control button was not aligned.What changed
apps/vscode/src/providers/views/PageStatus/PageStatus.tsxTASK_STATE.STOPPINGcase ingetControlButton()returning{ label: 'Stopping...', disabled: true, className: 'action-btn stopping-btn disabled' }apps/vscode/src/providers/views/PageStatus/styles.css.action-btn.stopping-btnstyle: orange background (--vscode-charts-orange), white text,cursor: not-allowedValidation
RUNNING/INITIALIZING/default cases are untouched--vscode-charts-orangeCSS variable already used for stopping indicators elsewhere in the codebaseHow this could be extended
Closes: N/A — this is a duplicate of the change in PR #549; only one should be merged
#Hack-with-bay-2