Skip to content

feat(nodes): add batch processing node for large dataset pipelines #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
charliegillet wants to merge 1 commit into from
+9 −0
Closed

feat(nodes): add batch processing node for large dataset pipelines #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/vscode/src/providers/views/PageStatus/PageStatus.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,9 @@ export const PageStatus: React.FC = () => {
const state = taskStatus?.state ?? TASK_STATE.NONE;
const runLabel = tracingEnabled ? 'Run & Trace' : 'Run';

if (state === TASK_STATE.STOPPING) {
return { label: 'Stopping...', action: 'stop' as const, disabled: true, className: 'action-btn stopping-btn disabled' };
}
if (state === TASK_STATE.RUNNING || state === TASK_STATE.INITIALIZING) {
return { label: 'Stop', action: 'stop' as const, disabled: false, className: 'action-btn stop-btn' };
}
Expand Down
6 changes: 6 additions & 0 deletions apps/vscode/src/providers/views/PageStatus/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,12 @@
background: var(--vscode-errorForeground);
}

.action-btn.stopping-btn {
background: var(--vscode-charts-orange);
color: white;
cursor: not-allowed;
}
Comment on lines +309 to +313
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Prevent hover animation on disabled “Stopping...” control.

Line 309-Line 313 defines a disabled visual state, but .action-btn:hover still applies transform/shadow. This makes a disabled control look interactive.

🎯 Proposed CSS fix 
 .action-btn.stopping-btn {
 	background: var(--vscode-charts-orange);
 	color: white;
 	cursor: not-allowed;
 }
+
+.action-btn.disabled:hover,
+.action-btn.stopping-btn:hover {
+	transform: none;
+	box-shadow: none;
+	background: var(--vscode-charts-orange);
+}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
.action-btn.stopping-btn {
background: var(--vscode-charts-orange);
color: white;
cursor: not-allowed;
}
.action-btn.stopping-btn {
background: var(--vscode-charts-orange);
color: white;
cursor: not-allowed;
}
.action-btn.disabled:hover,
.action-btn.stopping-btn:hover {
transform: none;
box-shadow: none;
background: var(--vscode-charts-orange);
}
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@apps/vscode/src/providers/views/PageStatus/styles.css` around lines 309 -
313, The stopping-btn state still receives the interactive hover styles from
.action-btn:hover; update the CSS so .action-btn.stopping-btn cancels hover
effects by overriding the hover selector (e.g. add a
.action-btn.stopping-btn:hover rule) and explicitly disable interaction
(pointer-events: none or equivalent), and reset transform/box-shadow/transition
so the “Stopping...” control no longer animates or appears interactive; target
.action-btn.stopping-btn and .action-btn.stopping-btn:hover to implement these
overrides.


.action-btn.run-btn {
background: var(--vscode-charts-green);
color: white;
Expand Down
Loading