feat(nodes): add anomaly detection node for pipeline output monitoring#555
feat(nodes): add anomaly detection node for pipeline output monitoring#555charliegillet wants to merge 1 commit into
Conversation
…screen Handle TASK_STATE.STOPPING in the control button to show "Stopping..." with a disabled state and distinct orange styling, preventing duplicate clicks and giving immediate visual feedback during pipeline shutdown. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughThese changes add explicit handling for a "stopping" state transition in the PageStatus component. The TypeScript logic now includes a dedicated branch for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing — PR shipped incorrect code (PageStatus change instead of the claimed feature). The actual feature code landed in a different PR. |
Summary
TASK_STATE.STOPPINGhandling to the pipeline status control button in the VS Code extensionType
Bug Fix (UX)
Why this bug happens in this codebase
The
getControlButton()function inPageStatus.tsxhandlesTASK_STATE.RUNNINGandTASK_STATE.INITIALIZINGbut did not handleTASK_STATE.STOPPING. When a pipeline entered the stopping state, the button fell through to the default case and showed a disabled "Run" button — confusing because it gave no indication that a stop was in progress.The codebase already defines
TASK_STATE.STOPPINGin its state enum and theStatusHeadercomponent already renders an orange "Stopping" indicator dot for this state, but the control button was not aligned.What changed
apps/vscode/src/providers/views/PageStatus/PageStatus.tsxTASK_STATE.STOPPINGcase ingetControlButton()returning{ label: 'Stopping...', disabled: true, className: 'action-btn stopping-btn disabled' }apps/vscode/src/providers/views/PageStatus/styles.css.action-btn.stopping-btnstyle: orange background (--vscode-charts-orange), white text,cursor: not-allowedValidation
RUNNING/INITIALIZING/default cases are untouched--vscode-charts-orangeCSS variable already used for stopping indicators elsewhere in the codebaseHow this could be extended
Closes: N/A — this is a duplicate of the change in PR #549; only one should be merged
#Hack-with-bay-2