fix: replace mutable default arguments with None#582
Merged
stepmikhaylov merged 2 commits intoApr 7, 2026
Merged
Conversation
charliegillet
requested review from
Rod-Christensen,
jmaionchi and
stepmikhaylov
as code owners
github-actions
Bot
added
module:nodes
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughA multi-file refactor replaces mutable default arguments (empty dicts and lists) with Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/vscode/src/providers/views/PageStatus/styles.css`:
- Around line 309-313: The .action-btn.stopping-btn rule currently styles the
disabled Stopping... state but .action-btn:hover still applies lift/shadow;
update the CSS to override hover for this disabled variant by adding a selector
targeting .action-btn.stopping-btn:hover (or .action-btn.stopping-btn:disabled
if applicable) and suppress the hover effects (no transform, no box-shadow) and
keep cursor: not-allowed so the button remains visually non-interactive; modify
the rules near .action-btn.stopping-btn to include this hover override
referencing the .action-btn.stopping-btn selector.
In `@packages/ai/src/ai/modules/remote/__init__.py`:
- Line 9: Update the initModule signature to use a proper optional type and mark
the unused parameter to satisfy type checkers and lint: change the parameter
annotation from "config: Autopipe = None" to "config: Optional[Autopipe] = None"
(and add Optional to the imports) and rename the parameter to _config (or prefix
with _) so Ruff no longer flags it as unused; ensure the function name
initModule and its callers remain unchanged.
In `@packages/ai/src/ai/modules/remote/remote.py`:
- Line 13: Replace the Cyrillic capital ES (U+0421) at the start of the
docstring "Сreate an instance of the pipe context." with a Latin capital C
(U+0043) so the docstring reads "Create an instance of the pipe context.";
locate the exact docstring text in packages/ai/src/ai/modules/remote/remote.py
(search for "Сreate an instance of the pipe context.") and update the character
only, leaving the rest of the docstring and surrounding code (e.g., any function
or class that contains this docstring) unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: ab662dde-b9d3-4110-865a-af574fb17c3d
📒 Files selected for processing (9)
apps/vscode/src/providers/views/PageStatus/PageStatus.tsxapps/vscode/src/providers/views/PageStatus/styles.cssnodes/src/nodes/autopipe/IGlobal.pypackages/ai/src/ai/account/keystore.pypackages/ai/src/ai/common/dap/dap_conn.pypackages/ai/src/ai/modules/remote/__init__.pypackages/ai/src/ai/modules/remote/remote.pypackages/ai/src/ai/modules/task/task_conn.pypackages/ai/src/ai/web/server.py
stepmikhaylov
force-pushed
the
fix/mutable-default-args
branch
from
ca31e7d to
ff289fd
Compare
stepmikhaylov
previously approved these changes
Apr 2, 2026
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
nodes/src/nodes/autopipe/IGlobal.py (1)
49-56:⚠️ Potential issue | 🟡 MinorAdd
# noqa: A002to suppress builtin shadowing on parameterid.Line 49 shadows Python's builtin
id, which Ruff flags as an error. Per established pattern in similar node files (agent_langchain, agent_deepagent), suppress the violation with a targeted noqa comment rather than renaming.- def getFilter(id: str, provider: str, config: Optional[Dict] = None): + def getFilter(id: str, provider: str, config: Optional[Dict] = None): # noqa: A002🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@nodes/src/nodes/autopipe/IGlobal.py` around lines 49 - 56, The parameter name id in function getFilter shadows the Python builtin and should be suppressed with a targeted noqa rather than renamed; update the getFilter signature to append the inline comment "# noqa: A002" (i.e., def getFilter(id: str, provider: str, config: Optional[Dict] = None): # noqa: A002) so Ruff ignores the A002 builtin-shadowing warning while leaving parameter name and logic in getFilter unchanged.
♻️ Duplicate comments (1)
packages/ai/src/ai/modules/remote/__init__.py (1)
9-9:⚠️ Potential issue | 🟡 MinorUse an explicit optional annotation and mark the unused parameter intentionally.
Line 9 sets
Noneas default while annotatingAutopipe, andconfigis still unused. This keeps type-check/lint noise around.Proposed fix
+from typing import Optional from ai.web import WebServer from ai.common.schema import Autopipe @@ -def initModule(server: WebServer, config: Autopipe = None): +def initModule(server: WebServer, _config: Optional[Autopipe] = None) -> None:🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/ai/src/ai/modules/remote/__init__.py` at line 9, The function initModule currently declares config: Autopipe = None and doesn't use it; change the annotation to an explicit optional type and mark the parameter as intentionally unused: annotate config as Optional[Autopipe] (import Optional if needed) and either rename the parameter to _config or add a deliberate discard (e.g., assign config to _ or add a comment/pragma) so linters/type-checkers stop flagging it; refer to initModule, the config parameter, Autopipe and WebServer when locating the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/ai/src/ai/account/keystore.py`:
- Line 35: KeyStore.__init__ currently calls super().__init__(config if config
is not None else {}, **kwargs) but KeyStore has no base class so this invokes
object.__init__ with arguments and raises TypeError; remove that
super().__init__ call and instead directly assign the resolved config to the
instance (e.g., set self.config or the appropriate attribute) inside
KeyStore.__init__, ensuring any kwargs are handled or rejected as needed.
In `@packages/ai/src/ai/modules/remote/remote.py`:
- Around line 11-19: The constructor parameter name input in remote.py's
__init__ shadows the built-in; rename the parameter (and internal attribute) to
inputs (or similar) in the __init__ signature and body (e.g., change input ->
inputs and self.input -> self.inputs) and update any other references to use the
new name (including usages of the attribute elsewhere in the module or project)
to eliminate the A002 shadowing warning while preserving the same default
behavior (use empty list when None).
---
Outside diff comments:
In `@nodes/src/nodes/autopipe/IGlobal.py`:
- Around line 49-56: The parameter name id in function getFilter shadows the
Python builtin and should be suppressed with a targeted noqa rather than
renamed; update the getFilter signature to append the inline comment "# noqa:
A002" (i.e., def getFilter(id: str, provider: str, config: Optional[Dict] =
None): # noqa: A002) so Ruff ignores the A002 builtin-shadowing warning while
leaving parameter name and logic in getFilter unchanged.
---
Duplicate comments:
In `@packages/ai/src/ai/modules/remote/__init__.py`:
- Line 9: The function initModule currently declares config: Autopipe = None and
doesn't use it; change the annotation to an explicit optional type and mark the
parameter as intentionally unused: annotate config as Optional[Autopipe] (import
Optional if needed) and either rename the parameter to _config or add a
deliberate discard (e.g., assign config to _ or add a comment/pragma) so
linters/type-checkers stop flagging it; refer to initModule, the config
parameter, Autopipe and WebServer when locating the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 971b6bc9-676e-4238-8606-388641965c75
📒 Files selected for processing (7)
nodes/src/nodes/autopipe/IGlobal.pypackages/ai/src/ai/account/keystore.pypackages/ai/src/ai/common/dap/dap_conn.pypackages/ai/src/ai/modules/remote/__init__.pypackages/ai/src/ai/modules/remote/remote.pypackages/ai/src/ai/modules/task/task_conn.pypackages/ai/src/ai/web/server.py
stepmikhaylov
force-pushed
the
fix/mutable-default-args
branch
from
5060d22 to
ff289fd
Compare
stepmikhaylov
requested changes
Apr 2, 2026
Collaborator
stepmikhaylov
left a comment
stepmikhaylov
left a comment
There was a problem hiding this comment.
Hey @charliegillet ,
Thank you for this refactor of python defaults. CodeRabbit reported critical issues. Would you have a chance to take a look?
charliegillet
added a commit
to charliegillet/rocketride-server
that referenced
this pull request
Apr 3, 2026
- Fix invalid super().__init__ call in KeyStore (TypeError at runtime) - Fix type annotation: use Optional[Autopipe] and prefix unused config param - Fix Cyrillic 'С' typo in docstring (RUF002) - Rename 'input' parameter to 'input_keys' to avoid shadowing builtin (A002) - Add hover override for disabled stopping button CSS Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
auto-merge was automatically disabled
April 3, 2026 03:17
Head branch was pushed to by a user without write access
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/ai/src/ai/modules/remote/__init__.py (1)
17-19:⚠️ Potential issue | 🟡 MinorDocstring references stale parameter name.
The docstring still documents
configbut the parameter was renamed to_config.Proposed fix
Args: server (WebServer): The web server instance where routes will be registered. - config (Dict[str, Any]): Configuration settings for the module. + _config (Optional[Autopipe]): Configuration settings for the module (unused).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/ai/src/ai/modules/remote/__init__.py` around lines 17 - 19, The docstring in packages/ai/src/ai/modules/remote/__init__.py refers to a parameter named `config` that was renamed to `_config`; update the Args section to reference `_config` (and adjust its description if needed) so it matches the actual function signature (e.g., the constructor or register function that accepts `server` and `_config`), and ensure any other occurrences of `config` in that docstring are replaced with `_config`.
♻️ Duplicate comments (1)
packages/ai/src/ai/account/keystore.py (1)
19-27:⚠️ Potential issue | 🟡 MinorReject unknown
**kwargsor remove them from the signature.Now that
super().__init__(..., **kwargs)is gone, extra keywords are accepted and then ignored. That turns misspelled options into silent no-ops. IfKeyStoreis not required to keep a variadic constructor, drop**kwargs; otherwise fail when it is non-empty.🛠️ Proposed fix if unknown kwargs should be rejected
- def __init__(self, config: Optional[Dict[str, Any]] = None, **kwargs) -> None: + def __init__(self, config: Optional[Dict[str, Any]] = None, **kwargs: Any) -> None: """ Initialize the keystore with configuration and optional parameters. Args: config (Dict[str, Any]): Configuration dictionary for the server. **kwargs: Additional keyword arguments for customization. """ + if kwargs: + unexpected = ", ".join(sorted(kwargs)) + raise TypeError(f'Unexpected keyword arguments: {unexpected}') + # Create the token map🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/ai/src/ai/account/keystore.py` around lines 19 - 27, The __init__ of KeyStore currently accepts **kwargs but ignores them (super().__init__(..., **kwargs) was removed), which hides misspelled options; either remove the **kwargs parameter from KeyStore.__init__ so unknown keywords are not accepted, or if variadic kwargs must remain, add explicit validation at the top of KeyStore.__init__ to raise a TypeError when kwargs is non-empty (e.g., "Unexpected keyword arguments: {list(kwargs.keys())}"), ensuring callers and typos fail fast rather than becoming silent no-ops.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/ai/src/ai/modules/remote/remote.py`:
- Line 1: Update the imports and type hints in remote.py to use Python 3.12
built-in generics: change the top-level import "from typing import Any, Dict,
List, Optional" to "from typing import Any" and then replace all occurrences of
Dict[...] with dict[...], List[...] with list[...], and Optional[T] with T |
None (or the equivalent union) in function signatures, method annotations, and
class attributes (e.g., any functions or classes that reference Dict, List,
Optional in remote.py).
---
Outside diff comments:
In `@packages/ai/src/ai/modules/remote/__init__.py`:
- Around line 17-19: The docstring in
packages/ai/src/ai/modules/remote/__init__.py refers to a parameter named
`config` that was renamed to `_config`; update the Args section to reference
`_config` (and adjust its description if needed) so it matches the actual
function signature (e.g., the constructor or register function that accepts
`server` and `_config`), and ensure any other occurrences of `config` in that
docstring are replaced with `_config`.
---
Duplicate comments:
In `@packages/ai/src/ai/account/keystore.py`:
- Around line 19-27: The __init__ of KeyStore currently accepts **kwargs but
ignores them (super().__init__(..., **kwargs) was removed), which hides
misspelled options; either remove the **kwargs parameter from KeyStore.__init__
so unknown keywords are not accepted, or if variadic kwargs must remain, add
explicit validation at the top of KeyStore.__init__ to raise a TypeError when
kwargs is non-empty (e.g., "Unexpected keyword arguments:
{list(kwargs.keys())}"), ensuring callers and typos fail fast rather than
becoming silent no-ops.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 0c1a01af-90e1-41c2-8341-eed872f53d02
📒 Files selected for processing (3)
packages/ai/src/ai/account/keystore.pypackages/ai/src/ai/modules/remote/__init__.pypackages/ai/src/ai/modules/remote/remote.py
Contributor
Author
|
Addressed all review feedback (CodeRabbit critical issues):
Thanks for flagging the CodeRabbit issues! |
stepmikhaylov
previously approved these changes
Apr 6, 2026
Collaborator
|
Thank you for addressing CodeRabbit concerns. It's almost fine, the only conflict needs resolution to makes this ready to go. |
charliegillet
force-pushed
the
fix/mutable-default-args
branch
from
d4b1229 to
a44e5e4
Compare
charliegillet
added a commit
to charliegillet/rocketride-server
that referenced
this pull request
Apr 6, 2026
- Fix invalid super().__init__ call in KeyStore (TypeError at runtime) - Fix type annotation: use Optional[Autopipe] and prefix unused config param - Fix Cyrillic 'С' typo in docstring (RUF002) - Rename 'input' parameter to 'input_keys' to avoid shadowing builtin (A002) - Add hover override for disabled stopping button CSS Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Rebased on develop and resolved the merge conflict in |
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
packages/ai/src/ai/modules/remote/__init__.py (1)
11-20:⚠️ Potential issue | 🟡 MinorSync the docstring with the new
_configsignature.Line 11 renamed the parameter, but the docstring still documents
configand unrelated/api/v0routes. Please update the summary and Args section so help text matches the actual remote module registration.📝 Suggested docstring update
def initModule(server: WebServer, _config: Optional[Autopipe] = None): """ - Initialize the module by registering API routes for search and configuration. - - Route GET, POST `/api/v0`: Calls `api_v0` for handling API requests. + Initialize the remote module routes. Args: server (WebServer): The web server instance where routes will be registered. - config (Dict[str, Any]): Configuration settings for the module. + _config (Optional[Autopipe]): Optional module configuration. Unused here. """🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/ai/src/ai/modules/remote/__init__.py` around lines 11 - 20, Update the docstring for initModule to reflect the actual signature and responsibilities: change the summary to say it initializes the remote module by registering its routes, remove the stale mention of GET/POST `/api/v0`, and update the Args to document server: WebServer and _config: Optional[Autopipe] (describe its purpose or that it may be None), replacing the old `config: Dict[str, Any]` entry; keep the brief one-line description of behavior and any return/side-effect notes about route registration.nodes/src/nodes/autopipe/IGlobal.py (1)
49-55:⚠️ Potential issue | 🟡 MinorFix the helper signature to resolve Ruff A002 and ANN202.
The parameter
idshadows Python's builtin. Rename it tofilter_idand add the missing return annotation-> Dict[str, Any]to match the pattern already used elsewhere in this file (e.g.,pushLocal,pushRemote).Minimal fix
- def getFilter(id: str, provider: str, config: Optional[Dict] = None): + def getFilter(filter_id: str, provider: str, config: Optional[Dict[str, Any]] = None) -> Dict[str, Any]: if config is None: config = {} filter = {} - filter['id'] = id + filter['id'] = filter_id🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@nodes/src/nodes/autopipe/IGlobal.py` around lines 49 - 55, Rename the parameter id to filter_id in the getFilter function and update internal uses (change filter['id'] = id to filter['id'] = filter_id), add the missing return type annotation -> Dict[str, Any] to the getFilter signature to satisfy ANN202, and ensure Any is imported from typing if not already present; also return the built dict at the end of getFilter (e.g., return filter).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@nodes/src/nodes/autopipe/IGlobal.py`:
- Around line 49-55: Rename the parameter id to filter_id in the getFilter
function and update internal uses (change filter['id'] = id to filter['id'] =
filter_id), add the missing return type annotation -> Dict[str, Any] to the
getFilter signature to satisfy ANN202, and ensure Any is imported from typing if
not already present; also return the built dict at the end of getFilter (e.g.,
return filter).
In `@packages/ai/src/ai/modules/remote/__init__.py`:
- Around line 11-20: Update the docstring for initModule to reflect the actual
signature and responsibilities: change the summary to say it initializes the
remote module by registering its routes, remove the stale mention of GET/POST
`/api/v0`, and update the Args to document server: WebServer and _config:
Optional[Autopipe] (describe its purpose or that it may be None), replacing the
old `config: Dict[str, Any]` entry; keep the brief one-line description of
behavior and any return/side-effect notes about route registration.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: bfcef882-d56b-4be6-bc0c-4a17ffc1e031
📒 Files selected for processing (6)
nodes/src/nodes/autopipe/IGlobal.pypackages/ai/src/ai/account/keystore.pypackages/ai/src/ai/common/dap/dap_conn.pypackages/ai/src/ai/modules/remote/__init__.pypackages/ai/src/ai/modules/remote/remote.pypackages/ai/src/ai/web/server.py
stepmikhaylov
approved these changes
Apr 7, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Fix invalid super().__init__ call in KeyStore (TypeError at runtime) - Fix type annotation: use Optional[Autopipe] and prefix unused config param - Fix Cyrillic 'С' typo in docstring (RUF002) - Rename 'input' parameter to 'input_keys' to avoid shadowing builtin (A002) - Add hover override for disabled stopping button CSS Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
stepmikhaylov
force-pushed
the
fix/mutable-default-args
branch
from
a44e5e4 to
fad1d66
Compare
|
No description provided. |
Collaborator
|
ℹ️ branch rebased to fix build failures |
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
nodes/src/nodes/autopipe/IGlobal.py (1)
49-56: 🧹 Nitpick | 🔵 TrivialMutable default argument fix looks correct.
The change from
config: Dict = {}toconfig: Optional[Dict] = Nonewith the guard at lines 50-51 correctly prevents shared state between function calls. This is a proper fix for the mutable default argument issue.However, note that
idshadows the Python builtin (Ruff A002). Consider renaming tofilter_idfor clarity.Optional fix for builtin shadowing
- def getFilter(id: str, provider: str, config: Optional[Dict] = None): + def getFilter(filter_id: str, provider: str, config: Optional[Dict] = None): if config is None: config = {} filter = {} - filter['id'] = id + filter['id'] = filter_id filter['provider'] = provider filter[provider] = config return filter,
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@nodes/src/nodes/autopipe/IGlobal.py` around lines 49 - 56, getFilter currently uses a parameter named id which shadows the Python builtin; rename the parameter to filter_id (and update the internal assignment filter['id'] = filter_id) in the getFilter function to avoid Ruff A002, and then update any callers of getFilter to pass the new filter_id argument name (or positional argument) accordingly; ensure you also update any references to the old parameter name within the function body.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@nodes/src/nodes/autopipe/IGlobal.py`:
- Around line 49-56: getFilter currently uses a parameter named id which shadows
the Python builtin; rename the parameter to filter_id (and update the internal
assignment filter['id'] = filter_id) in the getFilter function to avoid Ruff
A002, and then update any callers of getFilter to pass the new filter_id
argument name (or positional argument) accordingly; ensure you also update any
references to the old parameter name within the function body.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 06edb0bc-a30d-4d83-a4d6-a66973385a2f
📒 Files selected for processing (6)
nodes/src/nodes/autopipe/IGlobal.pypackages/ai/src/ai/account/keystore.pypackages/ai/src/ai/common/dap/dap_conn.pypackages/ai/src/ai/modules/remote/__init__.pypackages/ai/src/ai/modules/remote/remote.pypackages/ai/src/ai/web/server.py
shashidharbabu
pushed a commit
that referenced
this pull request
Apr 7, 2026
* fix: replace mutable default arguments with None to prevent shared state Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address CodeRabbit feedback on PR #582 - Fix invalid super().__init__ call in KeyStore (TypeError at runtime) - Fix type annotation: use Optional[Autopipe] and prefix unused config param - Fix Cyrillic 'С' typo in docstring (RUF002) - Rename 'input' parameter to 'input_keys' to avoid shadowing builtin (A002) - Add hover override for disabled stopping button CSS Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ryan-t-christensen
pushed a commit
that referenced
this pull request
Apr 8, 2026
* fix: replace mutable default arguments with None to prevent shared state Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address CodeRabbit feedback on PR #582 - Fix invalid super().__init__ call in KeyStore (TypeError at runtime) - Fix type annotation: use Optional[Autopipe] and prefix unused config param - Fix Cyrillic 'С' typo in docstring (RUF002) - Rename 'input' parameter to 'input_keys' to avoid shadowing builtin (A002) - Add hover override for disabled stopping button CSS Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[],{}) withNoneacross 7 Python files inpackages/ai/andnodes/to prevent shared state between function/method callsOptionaltype annotations andNoneguards in method bodies to preserve existing behaviorWhy this bug happens in this codebase
In Python, mutable default arguments (like
[]and{}) are evaluated once at function definition time, not at each call. This means all callers that rely on the default share the same object in memory. The most critical instance was inpackages/ai/src/ai/modules/remote/remote.py:11:Every
Pipeinstance created without explicitinput/outputargs shared the same list. Appending to one instance's list would silently mutate all others — a classic Python footgun. The same pattern existed in 6 other files across the codebase.Files changed
packages/ai/src/ai/modules/remote/remote.pyinput=[],output=[],usage={}→Nonepackages/ai/src/ai/modules/remote/__init__.pyconfig={}→Nonepackages/ai/src/ai/common/dap/dap_conn.pymessage={}→Nonepackages/ai/src/ai/modules/task/task_conn.pymessage={}→Nonepackages/ai/src/ai/account/keystore.pyconfig={}→Nonepackages/ai/src/ai/web/server.pyconfig={}→None(2 methods)nodes/src/nodes/autopipe/IGlobal.pyconfig={}→NoneTest plan
ruff checkandruff formatpass (confirmed locally)Pipe()instances have independentinput/output/usageattributes#Hack-with-bay-2
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Breaking Changes