Skip to content

fix(security): explicit branch check on nightly workflow_run trigger #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwit75 merged 2 commits into from
May 7, 2026
Merged

fix(security): explicit branch check on nightly workflow_run trigger #771

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5f3976
fix(security): explicit branch check on nightly workflow_run trigger
anandray May 6, 2026
46eefad
fix(security): restrict workflow_dispatch to develop ref
anandray May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion .github/workflows/nightly.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,24 @@ jobs:
init:
name: Initialize
# Skip when CI failed; manual dispatch always runs.
if: github.event_name == 'workflow_dispatch' || github.event.workflow_run.conclusion == 'success'
#
# The `head_branch == 'develop'` guard makes explicit what the
# `branches: [develop]` filter on the trigger already enforces:
# this workflow runs privileged jobs (secrets: inherit, contents:
# write) on the head_sha of the triggering CI run. Static analyzers
# (e.g. OSSF Scorecard's DangerousWorkflow rule) flag workflow_run
# patterns that checkout `head_sha` without a branch check, since
# in principle workflow_run can be triggered by CI runs on any
# branch and a checkout of an untrusted ref with secrets is the
# canonical supply-chain attack vector. The explicit branch check
# below ties the trust boundary to develop's branch protection
# (PR + code-owner review + required checks), which is the actual
# safety guarantee.
if: >
(github.event_name == 'workflow_dispatch' &&
github.ref == 'refs/heads/develop') ||
(github.event.workflow_run.conclusion == 'success' &&
github.event.workflow_run.head_branch == 'develop')
Comment thread
coderabbitai[bot] marked this conversation as resolved.
uses: ./.github/workflows/_init.yaml
with:
# `head_sha` pins the build to the exact commit whose CI passed,
Expand Down
Loading