Support Rocq 9.1 and 9.2#144
Merged
Merged
Conversation
Lift the coq version bound to < 9.3~ and add Rocq 9.1 and 9.2 to the CI matrix. Regenerated files kept in sync with meta.yml. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Rocq 9.2 drops the `coq` compatibility opam package, so `depends: coq` is unsatisfiable there. Depend on `rocq-core` for 9.x (keeping `coq` for 8.18-8.20), following the coq-community/tarjan and fourcolor pattern. coq-bignums already ships a +rocq9.2 build, so it is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
NB 9.3 was branched recently and is very unlikely to break mathclasses so <9.4 should work too |
SkySkimmer
reviewed
Jul 11, 2026
| # The coq-core/rocq-core split (Rocq 9.2 drops the `coq` compatibility | ||
| # package) means the compiler dependency must be hand-written as a | ||
| # disjunction in coq-math-classes.opam; this field is kept for reference. | ||
| opam: '{>= "8.18" & < "8.21~"} | "rocq-core" {(>= "9.0" & < "9.3~") | (= "dev")}' |
Contributor
There was a problem hiding this comment.
I think you still need coq-core (contains the coqc coq_makefile etc binaries)
9.3 is branched and does not break math-classes (Gaëtan Gilbert), so extend the rocq-core bound to < 9.4~.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds compatibility with the Rocq 9.1 and 9.2 releases so that a 9.2-compatible
coq-math-classescan be published (needed as a dependency for a Rocq 9.2 release of CoRN).Changes
meta.yml/coq-math-classes.opam: lift the coq bound from< "9.1~"to< "9.3~"..github/workflows/docker-action.yml: addrocq/rocq-prover:9.1androcq/rocq-prover:9.2to the CI matrix.The bound goes to
< "9.3~"(rather than< "9.2~") since master already tracksrocq-prover:dev; the new CI rows verify the 9.1 and 9.2 stable releases specifically.No source changes were needed beyond the version metadata — CI on the new rows is the verification.
🤖 Generated with Claude Code