Fix parsing of line lacking linefeed#236
Open
arteymix wants to merge 1 commit into
Open
Conversation
A line lacking a linefeed will appear as the last item when splitting newlines, and ends-up removed with the current logic. Instead, just check that every single line has something.
arteymix
force-pushed
the
fix-password-store-entries-lacking-linefeed
branch
from
e931f56 to
6ac3470
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A line lacking a linefeed will appear as the last item when splitting newlines, and ends-up removed with the current logic. Instead of popping the last item, just check that every single line has something.