Skip to content

Commit d966368

Browse files
authored
Security enhancements (#794)
1 parent 82fd536 commit d966368

17 files changed

Lines changed: 4166 additions & 2423 deletions

.github/workflows/build.yml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,21 +8,24 @@ on:
88
jobs:
99
ci:
1010
runs-on: ${{ matrix.os }}
11-
env:
12-
#just hardcode this. It's not a mission-critical token, and we can always change it
13-
COVERALLS_REPO_TOKEN: "Ysqq6q68DgojDzv3gvl5Yv029HXZYwGxq"
1411
strategy:
1512
matrix:
1613
os: [ubuntu-latest, macos-latest, windows-latest]
1714
steps:
1815
- uses: actions/checkout@master
1916
- uses: actions/setup-node@master
2017
with:
21-
node-version: "18.18.2"
18+
node-version: "18.20.4"
2219
- run: npm ci
2320
- run: npm run build
2421
- run: npm run lint
2522
- run: npm run test
26-
# disable coverage for now (because coveralls is down right now)
27-
#- run: npm run publish-coverage
2823
- run: npm run create-package
24+
- name: Upload coverage to Coveralls
25+
if: matrix.os == 'ubuntu-latest'
26+
uses: coverallsapp/github-action@v2
27+
env:
28+
#just hardcode this. It's not a mission-critical token, and we can always change it
29+
COVERALLS_REPO_TOKEN: "Ysqq6q68DgojDzv3gvl5Yv029HXZYwGxq"
30+
with:
31+
path-to-lcov: ./coverage/lcov.info

.github/workflows/create-vsix.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
- uses: actions/checkout@master
1313
- uses: actions/setup-node@master
1414
with:
15-
node-version: "18.18.2"
15+
node-version: "18.20.4"
1616
- run: npm ci
1717
- run: npx ts-node scripts/create-vsix.ts ${{ github.event.inputs.branch }}
1818
- uses: actions/upload-artifact@v4

.github/workflows/docs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
- uses: actions/checkout@master
1111
- uses: actions/setup-node@master
1212
with:
13-
node-version: "18.18.2"
13+
node-version: "18.20.4"
1414
- run: npm install
1515
- run: npm run build-docs
1616
- name: Deploy

.github/workflows/make-release-artifacts.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
uses: rokucommunity/workflows/.github/workflows/make-release-artifacts.yml@master
2525
with:
2626
branch: ${{ github.event.inputs.tag || github.event.pull_request.head.ref }}
27-
node-version: "18.18.2"
27+
node-version: "18.20.4"
2828
artifact-paths: "*.vsix"
2929
force: ${{ github.event.inputs.force == 'true' }}
3030
secrets: inherit
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
name: Security Audit
2+
on:
3+
push:
4+
branches:
5+
- master
6+
pull_request:
7+
schedule:
8+
#nightly at 06:00 UTC (1am EST / 2am EDT)
9+
- cron: '0 6 * * *'
10+
11+
jobs:
12+
audit:
13+
runs-on: ubuntu-latest
14+
steps:
15+
- uses: actions/checkout@master
16+
- uses: actions/setup-node@master
17+
with:
18+
node-version: "18.20.4"
19+
- run: npm ci
20+
- run: npm run audit

README.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
# BrightScript Language extension for VSCode
22

33
[![build status](https://img.shields.io/github/actions/workflow/status/rokucommunity/vscode-brightscript-language/build.yml?logo=github&branch=master)](https://github.com/rokucommunity/vscode-brightscript-language/actions/workflows/build.yml)
4+
[![security](https://img.shields.io/github/actions/workflow/status/rokucommunity/vscode-brightscript-language/security-audit.yml?branch=master&label=security&logo=data:image/svg%2Bxml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAxNiAxNiI+PHJlY3QgeD0iMyIgeT0iOCIgd2lkdGg9IjEwIiBoZWlnaHQ9IjciIHJ4PSIxIiBmaWxsPSJ3aGl0ZSIvPjxwYXRoIGQ9Ik01IDhWNWEzIDMgMCAwIDEgNiAwdjMiIGZpbGw9Im5vbmUiIHN0cm9rZT0id2hpdGUiIHN0cm9rZS13aWR0aD0iMiIvPjwvc3ZnPg==)](https://github.com/rokucommunity/vscode-brightscript-language/actions/workflows/security-audit.yml)
45
[![coverage status](https://img.shields.io/coveralls/github/rokucommunity/vscode-brightscript-language?logo=coveralls)](https://coveralls.io/github/rokucommunity/vscode-brightscript-language?branch=master)
56
[![Visual Studio Marketplace](https://vsmarketplacebadges.dev/installs-short/RokuCommunity.brightscript.png?logo=visual-studio-code)](https://marketplace.visualstudio.com/items?itemName=RokuCommunity.brightscript)
6-
[![Visual Studio Marketplace Version](https://img.shields.io/visual-studio-marketplace/v/RokuCommunity.brightscript.svg?logo=visual-studio-code&label=VSCode)](https://marketplace.visualstudio.com/items?itemName=RokuCommunity.brightscript)
7+
[![Visual Studio Marketplace Version](https://vsmarketplacebadges.dev/version/RokuCommunity.brightscript.png?logo=visual-studio-code&label=VSCode)](https://marketplace.visualstudio.com/items?itemName=RokuCommunity.brightscript)
78
[![OpenVSX](https://img.shields.io/open-vsx/v/RokuCommunity/brightscript.svg?label=OpenVSX)](https://open-vsx.org/extension/RokuCommunity/brightscript)
89
[![license](https://img.shields.io/github/license/rokucommunity/vscode-brightscript-language.svg)](LICENSE)
910
[![Slack](https://img.shields.io/badge/Slack-RokuCommunity-4A154B?logo=slack)](https://join.slack.com/t/rokudevelopers/shared_invite/zt-4vw7rg6v-NH46oY7hTktpRIBM_zGvwA)
@@ -60,6 +61,10 @@ For a full list of features and settings, please see our [documentation website]
6061

6162
The majority of this extension's language feature support depends on the [BrighterScript](https://github.com/RokuCommunity/brighterscript) project, which contributes the language server. The debugging functionality comes from the [roku-debug](https://github.com/RokuCommunity/roku-debug) project. If you would like to contribute please see our [contributing guide](https://rokucommunity.github.io/vscode-brightscript-language/contributing.html)
6263

64+
## Accepted security advisories
65+
66+
Dependencies flagged by `npm audit` that we have reviewed and chosen not to upgrade are tracked in [audit-ci.jsonc](https://github.com/RokuCommunity/vscode-brightscript-language/blob/master/audit-ci.jsonc). Each entry includes the advisory ID, the date it was added, and the reason it does not apply to this project.
67+
6368
## Changelog
6469

6570
Click [here](https://github.com/RokuCommunity/vscode-brightscript-language/blob/master/CHANGELOG.md) to see the changelog.

audit-ci.jsonc

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
{
2+
// Fail on moderate severity and above. See README "Accepted security advisories" for
3+
// why each allowlisted entry is safe to defer.
4+
"$schema": "https://github.com/IBM/audit-ci/raw/main/docs/schema.json",
5+
"moderate": true,
6+
"allowlist": [
7+
{
8+
"GHSA-2p57-rm9w-gvfp": {
9+
// Added: 2026-05-19
10+
"active": true,
11+
"notes": "`ip` (via `node-ssdp`): no fixed version published. `ip` is only used by `node-ssdp` for local-network Roku discovery; no untrusted input flows into `ip.isPublic()` in any path we control."
12+
}
13+
}
14+
]
15+
}

0 commit comments

Comments
 (0)