Security enhancements#794
Merged
Merged
Conversation
- Bump postman-request to ^2.88.1-postman.48 (patches qs runtime vuln) - Drop rimraf devDep; replace `clean` script with inline node fs.rmSync - Drop coveralls-next devDep, publish-coverage script, and CI step; comment out coveralls badge in README - Bump mocha 9 -> ^10.8.2 and @types/mocha 7 -> ^10.0.10 - Override serialize-javascript to ^7.0.5 (mocha 10 still pins ^6.0.2) - Bump CI node version to 18.20.4 across all workflows - Add `npm run audit` script that chains `npm audit || audit-ci` so the readable table from npm audit is shown alongside the audit-ci gate - Add audit-ci.jsonc with the `ip` (via node-ssdp) advisory allowlisted; no fixed version exists upstream and it does not reach untrusted input - Add `Accepted security advisories` section in README pointing at the jsonc allowlist Note: CI will fail on the ejs advisory (via statigen -> ejs-lint) until statigen is updated. Fix is being addressed in statigen separately.
statigen pulls in a vulnerable `ejs-lint` -> `ejs` chain that has no upstream fix. Moving the docs build into a sub-project (mirroring the `webviews/` pattern) keeps statigen's transitives out of the extension's own dependency tree so `npm audit` against the extension no longer flags the ejs advisory. - New `docs/package.json` with statigen as a local devDep - `build-docs` and `watch-docs` now `cd docs && npm install && ...` (install on demand to avoid burdening every `npm install`) - Drop `statigen` from the top-level devDeps
chrisdp
changed the title
undent 1.0.1 removes its `coveralls-next` runtime dep, which previously
pulled in vulnerable `js-yaml` 4.1.0. The API surface used by this
extension (`import undent from 'undent'` default and `import { undent }`
named) is unchanged in the 0.x -> 1.x bump.
Adopts the pattern from TwitchBronBron/undent#3: - Add `lcovonly` to nyc reporters so `coverage/lcov.info` is generated - Add the `coverallsapp/github-action@v2` step, gated to `ubuntu-latest` so the matrix doesn't double-upload - Move the coveralls token from the job-level env into the action's env - Un-comment the coveralls badge in README.md
|
Coverage is 54.915% — chris/npm-audit-cleanup into master. No base build found for |
Runs `npm run audit` on PRs and master pushes so the audit posture is gated independently of the larger `build` workflow. Removes the redundant `npm run audit` step from `build.yml` since the new workflow runs the same check in parallel.
Without an explicit `label` query param, shields.io defaults to "build" for the github/actions/workflow/status endpoint.
shields.io retired the visual-studio-marketplace/v endpoint, so the badge had been rendering as 'retired badge'. Switch to vsmarketplacebadges.dev, which is already used by the installs badge on the line above, and pass label=VSCode to keep the badge compact.
TwitchBronBron
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postman-requestto^2.88.1-postman.48(patches the runtimeqsvuln)rimrafdevDep;cleanscript now uses inlinenode -e "...fs.rmSync..."coveralls-nextdevDep,publish-coveragescript, and the commented-out CI step; coveralls badge commented out in READMEmocha9 →^10.8.2and@types/mocha7 →^10.0.1018.20.4acrossbuild.yml,create-vsix.yml,docs.yml, andmake-release-artifacts.ymloverridesentry forserialize-javascript^7.0.5(mocha 10 still pins^6.0.2)audit-cidevDep and anaudit-ci.jsoncallowlist. Theipadvisory (vianode-ssdp) is allowlisted: no upstream fix is published andipdoes not reach any untrusted-input path in this extensionnpm run auditscript that chainsnpm audit || audit-ciso the readablenpm audittable is shown alongside the audit-ci gate; wired into CI betweenlintandtestAccepted security advisoriessection in the README pointing ataudit-ci.jsoncKnown follow-up
CI will fail on the
ejsadvisory (GHSA-ghr5-ch3p-vcr6) reaching throughstatigen → ejs-lint → ejs.statigenis being fixed separately; this PR will pass CI oncestatigenships a release with the patchedejs-lint.