Fix npm audit issues in webviews#795
Merged
TwitchBronBron merged 3 commits intoMay 19, 2026
Merged
Conversation
- svelte 3.54 -> 5.55, vite 4 -> 8, @sveltejs/vite-plugin-svelte 2 -> 7, svelte-check 2 -> 4, @tsconfig/svelte 3 -> 5, typescript 4.9 -> 5.5, svelte-codicons 0.10 -> 0.21 - Wrap top-level `<tr>` in `<tbody>` in 3 svelte files (svelte 5 enforces the HTML structure the browser would otherwise auto-repair) - Add `moduleResolution: "node"` to webviews/tsconfig.json (TS 5 with `module: "ESNext"` would otherwise default to "classic", which is incompatible with `resolveJsonModule`) - Set `strict: false` in webviews/tsconfig.json to preserve the looser baseline svelte 3/TS 4.9 was running; the 272 type errors svelte 5/TS 5 would surface are real but pre-existing latent issues, tracked separately - Add `audit` script to webviews and cascade it from the top-level `audit` script so `npm run audit` covers both packages Clears 15 webviews vulnerabilities; 0 vulns remain in webviews.
chrisdp
changed the title
vite 7+ and 8+ require Node 20.19+ / 22.12+. CI runs Node 18.20.4, so the previous bump to vite 8 broke `npm run build` in CI with "Vite requires Node.js version 20.19+ or 22.12+". vite 6.4.2 is the latest in the 6.x line that supports Node 18 and is outside the audit's vulnerable range (`vite <=6.4.1`). Pair it with `@sveltejs/vite-plugin-svelte` ^5.1.1, the latest plugin that peers against vite 6 and still supports Node 18.
|
Coverage is 54.915% — task/upgrade-webviews-deps into chris/npm-audit-cleanup. No base build found for |
TwitchBronBron
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched from #794. Targets
chris/npm-audit-cleanup.Summary
svelte3.54 → 5.55,vite4 → 8,@sveltejs/vite-plugin-svelte2 → 7,svelte-check2 → 4,@tsconfig/svelte3 → 5,typescript4.9 → 5.5,svelte-codicons0.10 → 0.21<tr>in<tbody>in 3 svelte files; svelte 5 now enforces HTML structure that the browser would otherwise auto-repairmoduleResolution: "node"towebviews/tsconfig.json(TS 5 withmodule: "ESNext"defaults to"classic", which is incompatible withresolveJsonModule)strict: falseinwebviews/tsconfig.jsonto preserve the looser baseline that svelte 3 / TS 4.9 was runningauditscript inwebviews/package.jsonand cascaded it from the top-levelauditscriptKnown follow-up
Setting
strict: falsemasks 272 latent type-safety issues that the new toolchain would otherwise surface. They are not regressions caused by this PR — the code is identical — but represent pre-existing implicit-any and possibly-undefined patterns that the older toolchain didn't catch. Re-enablingstrict: trueand fixing these is a worthwhile follow-up but out of scope here.