Fix nested namespace display and nesting in outline#848
Open
chrisdp wants to merge 1 commit into
Open
Conversation
The document symbol outline (used when the language server is disabled) showed nested namespaces by their full dotted name and mis-nested them: a function over-extended its range and swallowed a following namespace, and namespaces never got an end-of-block range so their members flattened. - Show only the final namespace segment (`deep` for `get.deep`) - Reset the current function at `end function`/`end sub` - Track open containers with a stack and close each at its matching `end`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the document symbol outline (used when the language server is disabled) for nested namespaces.
Previously a nested namespace showed its full dotted name and was mis-nested: the function preceding it over-extended its range and swallowed the namespace, and namespaces never got an end-of-block range so their members flattened up to the parent.
deepinstead ofget.deep), matching the language serverend function/end subso it no longer over-extends past its own bodyend, so members nest under the correct parentCloses #554