fix: move dayjs to prod dependencies#850
Merged
Merged
Conversation
dayjs is imported at extension-activation runtime in LanguageServerInfoCommand.ts and LanguageServerManager.ts, but was listed under devDependencies. When the extension is packaged into a .vsix, devDependencies are stripped, so the installed build failed to activate with "Cannot find module 'dayjs/plugin/relativeTime'". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
chrisdp
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
2.67.1extension crashes on activation with:Root cause
dayjsis imported at extension-activation runtime:src/commands/LanguageServerInfoCommand.ts—import * as relativeTime from 'dayjs/plugin/relativeTime'andimport * as dayjs from 'dayjs'src/LanguageServerManager.ts—import * as dayjs from 'dayjs'...but it was listed under
devDependencies. During packaging (vsce package),devDependenciesare stripped from the.vsix, sodayjswas absent from the installed extension and activation failed.This works fine in dev because devDependencies are installed locally.
Fix
Move
dayjsfromdevDependenciesback intodependenciesand update the lockfile.🤖 Generated with Claude Code