Conversation
…SourceFiles The ExampleModule trait defined moduleDir as a non-overriding def with an absolute path, causing millSourcePath to dispatch to the parent's default moduleDir. This left sources.dest empty and allSourceFiles empty, so no .class files were produced and example.jsoniter.Json was missing from the classpath (185 compilation errors). Fix by using override def with the same relative-path pattern as CoreModule. Also fix specFile path and cliBin usage.
- Replace VirtusLab/scala-cli-setup with actions/setup-java (no sbt needed)
- Replace 'sbt buildCliBinary test' with './mill tests.__.test'
- Replace 'sbt publishSigned sonaRelease' with './mill core.{jvm,native}.publish cli.publish'
The mill wrapper script in the project root bootstraps Mill 1.1.6 automatically.
…box violations - Replace hardcoded /home/roman/... path with TaskCtx.workspace (Mill's official API for the project root inside tasks) - Remove cliBinPath (wrote outside Task.dest, hit sandbox restriction); buildCliBinary now writes to Task.dest/cli - Fix testLocal sources to use moduleDir instead of os.pwd - Add import mill.api.TaskCtx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.