Skip to content

Commit 0c4d562

Browse files
authored
fix(logback): remove duplicate logger boundary check block
1 parent 292626d commit 0c4d562

1 file changed

Lines changed: 10 additions & 14 deletions

File tree

rollbar-logback/src/main/java/com/rollbar/logback/RollbarAppender.java

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -108,12 +108,12 @@ public String provide() {
108108
super.start();
109109
}
110110

111-
@Override
112-
protected void append(ILoggingEvent event) {
113-
if (isRollbarLogger(event.getLoggerName())) {
114-
addWarn("Recursive logging");
115-
return;
116-
}
111+
@Override
112+
protected void append(ILoggingEvent event) {
113+
if (isRollbarLogger(event.getLoggerName())) {
114+
addWarn("Recursive logging");
115+
return;
116+
}
117117

118118
IThrowableProxy throwableProxy = event.getThrowableProxy();
119119
ThrowableWrapper rollbarThrowableWrapper = buildRollbarThrowableWrapper(throwableProxy);
@@ -124,14 +124,10 @@ protected void append(ILoggingEvent event) {
124124

125125
}
126126

127-
private static boolean isRollbarLogger(String loggerName) {
128-
if (loggerName == null) {
129-
return false;
130-
}
131-
132-
return PACKAGE_NAME.equals(loggerName)
133-
|| loggerName.startsWith(PACKAGE_NAME + ".");
134-
}
127+
private static boolean isRollbarLogger(String loggerName) {
128+
if (loggerName == null) {
129+
return false;
130+
}
135131

136132
return PACKAGE_NAME.equals(loggerName)
137133
|| loggerName.startsWith(PACKAGE_NAME + ".");

0 commit comments

Comments
 (0)