Skip to content

Commit e63b0af

Browse files
committed
fix(android): classify captured logcat entries as log telemetry type
1 parent 0f13b1a commit e63b0af

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

rollbar-android/src/main/java/com/rollbar/android/LogcatTelemetryCapture.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ void processLine(String line) {
137137
}
138138

139139
try {
140-
tracker.recordManualEventFor(level, Source.CLIENT, message);
140+
tracker.recordLogEventFor(level, Source.CLIENT, message);
141141
} catch (Exception e) {
142142
// Never let a broken tracker kill the reader thread.
143143
}

rollbar-android/src/test/java/com/rollbar/android/LogcatTelemetryCaptureTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public void processLine_recordsWarningAtThreshold() {
6363

6464
capture.processLine("04-20 12:34:56.789 1234 5678 W MyTag: warn message");
6565

66-
verify(tracker).recordManualEventFor(eq(Level.WARNING), eq(Source.CLIENT), eq("warn message"));
66+
verify(tracker).recordLogEventFor(eq(Level.WARNING), eq(Source.CLIENT), eq("warn message"));
6767
}
6868

6969
@Test
@@ -72,7 +72,7 @@ public void processLine_recordsErrorAboveThreshold() {
7272

7373
capture.processLine("04-20 12:34:56.789 1234 5678 E MyTag: boom");
7474

75-
verify(tracker).recordManualEventFor(eq(Level.ERROR), eq(Source.CLIENT), eq("boom"));
75+
verify(tracker).recordLogEventFor(eq(Level.ERROR), eq(Source.CLIENT), eq("boom"));
7676
}
7777

7878
@Test
@@ -111,18 +111,18 @@ public void processLine_trimsTag() {
111111

112112
capture.processLine("04-20 12:34:56.789 1234 5678 W MyTag : message");
113113

114-
verify(tracker).recordManualEventFor(eq(Level.WARNING), eq(Source.CLIENT), eq("message"));
114+
verify(tracker).recordLogEventFor(eq(Level.WARNING), eq(Source.CLIENT), eq("message"));
115115
}
116116

117117
@Test
118118
public void processLine_trackerThrow_doesNotPropagate() {
119119
doThrow(new RuntimeException("tracker boom"))
120-
.when(tracker).recordManualEventFor(any(), any(), any());
120+
.when(tracker).recordLogEventFor(any(), any(), any());
121121
LogcatTelemetryCapture capture = newCapture(Level.WARNING);
122122

123123
capture.processLine("04-20 12:34:56.789 1234 5678 W MyTag: message");
124124

125-
verify(tracker).recordManualEventFor(eq(Level.WARNING), eq(Source.CLIENT), eq("message"));
125+
verify(tracker).recordLogEventFor(eq(Level.WARNING), eq(Source.CLIENT), eq("message"));
126126
}
127127

128128
@Test
@@ -131,18 +131,18 @@ public void processLine_messageWithColon_preserved() {
131131

132132
capture.processLine("04-20 12:34:56.789 1234 5678 W MyTag: key: value");
133133

134-
verify(tracker).recordManualEventFor(eq(Level.WARNING), eq(Source.CLIENT), eq("key: value"));
134+
verify(tracker).recordLogEventFor(eq(Level.WARNING), eq(Source.CLIENT), eq("key: value"));
135135
}
136136

137137
@Test
138138
public void processLine_defaultsToWarningWhenMinLevelIsNull() {
139139
LogcatTelemetryCapture capture = newCapture(null);
140140

141141
capture.processLine("04-20 12:34:56.789 1234 5678 I MyTag: info");
142-
verify(tracker, never()).recordManualEventFor(any(), any(), any());
142+
verify(tracker, never()).recordLogEventFor(any(), any(), any());
143143

144144
capture.processLine("04-20 12:34:56.789 1234 5678 W MyTag: warn");
145-
verify(tracker).recordManualEventFor(eq(Level.WARNING), eq(Source.CLIENT), eq("warn"));
145+
verify(tracker).recordLogEventFor(eq(Level.WARNING), eq(Source.CLIENT), eq("warn"));
146146
}
147147

148148
@Test

0 commit comments

Comments
 (0)