Change parameters from switch to boolean type

Author: rolling-code

Azure Active Directory/MSADPT/MSADPT_audit_adcs_esc1_esc16.ps1

@@ -74,18 +74,21 @@
 
 param(
     [Parameter(Mandatory)]
+	[ValidateNotNullOrEmpty()]
     [string]$OutputBaseDir,
 
     [Parameter(Mandatory)]
-    [switch]$IncludeUnpublishedTemplates,
+    [bool]$IncludeUnpublishedTemplates,
 
     [Parameter(Mandatory)]
-    [switch]$SkipRemoteChecks,
+    [bool]$SkipRemoteChecks,
 
     [Parameter(Mandatory)]
+	[ValidateNotNullOrEmpty()]
     [string]$DirectoryServer,
 
     [Parameter(Mandatory)]
+	[ValidateNotNull()]
     [PSCredential]$Credential
 )
 
@@ -421,12 +424,21 @@ function Add-ESCFinding {
 # ---------------------------------------------------------------------
 $adSplat = New-MSADPTAdCommandSplat -Server $DirectoryServer -Credential $Credential
 
+# ---------------------------------------------------------------------
+# Pre-flight: AD connectivity check
+# ---------------------------------------------------------------------
+$rootDSE = Test-MSADPTADConnectivity -Credential $Credential -AdServer $DirectoryServer
+if (-not $rootDSE) {
+    Write-Log -Message "Active Directory connectivity pre-flight failed. Aborting." -Level 'ERROR'
+    exit 1
+}
+
 # ---------------------------------------------------------------------
 # Enumerate AD CS / PKI objects
 # ---------------------------------------------------------------------
 try {
-    $rootDse = Get-ADRootDSE @adSplat -ErrorAction Stop
-    $configNc = $rootDse.configurationNamingContext
+    #$rootDse = Get-ADRootDSE @adSplat -ErrorAction Stop
+    $configNc = $rootDSE.configurationNamingContext
 
     $templatesBase   = "CN=Certificate Templates,CN=Public Key Services,CN=Services,$configNc"
     $enrollmentBase  = "CN=Enrollment Services,CN=Public Key Services,CN=Services,$configNc"