fix regression of (condition || true) case

Author: moon-stripe

packages/commonjs/src/ast-utils.js

@@ -1,5 +1,19 @@
 export { default as isReference } from 'is-reference';
 
+function triStateAnd(a, b) {
+  if (a === false) return false;
+  if (b === false) return false;
+  if (a === true && b === true) return true;
+  return null;
+}
+
+function triStateOr(a, b) {
+  if (a === true) return true;
+  if (b === true) return true;
+  if (a === false && b === false) return false;
+  return null;
+}
+
 const operators = {
   '==': (x) => equals(x.left, x.right, false),
 
@@ -11,20 +25,9 @@ const operators = {
 
   '!': (x) => isFalsy(x.argument),
 
-  '&&': (x) => isTruthy(x.left) && isTruthy(x.right),
-
-  '||': (x) => {
-    const leftTruthy = isTruthy(x.left);
-    const rightTruthy = isTruthy(x.right);
-    // If left is definitely truthy, the whole expression is truthy
-    if (leftTruthy === true) return true;
-    // If both are definitely falsy, the whole expression is falsy
-    if (leftTruthy === false && rightTruthy === false) return false;
-    // If left is falsy but right is truthy, the whole expression is truthy
-    if (leftTruthy === false && rightTruthy === true) return true;
-    // Otherwise it's conditional
-    return null;
-  }
+  '&&': (x) => triStateAnd(isTruthy(x.left), isTruthy(x.right)),
+
+  '||': (x) => triStateOr(isTruthy(x.left), isTruthy(x.right))
 };
 
 function not(value) {
@@ -137,3 +140,4 @@ export function hasDefineEsmProperty(node) {
     return false;
   });
 }
+

packages/commonjs/test/fixtures/form/conditional-exports-or-true/output.js

@@ -14,7 +14,7 @@ function requireInput () {
 	if (condition || true) {
 	  input.handler = prodHandler;
 	} else {
-	  input.handler = defaultHandler;
+	  exports.handler = defaultHandler;
 	}
 	return input;
 }