Merge pull request #2 from vinny-silveira/copilot/add-jsx-runtime-support

Address review feedback and improve test coverage

Author: vinny-silveira

packages/sucrase/test/fixtures/inject-create-require/main.ts

@@ -0,0 +1,3 @@
+import foo = require('foo');
+
+export default foo;

packages/sucrase/test/fixtures/jsx-import-source/example.jsx

@@ -0,0 +1 @@
+export default () => <div id="foo">hello world</div>

packages/sucrase/test/fixtures/jsx-import-source/main.js

@@ -0,0 +1,4 @@
+/* eslint-disable import/extensions */
+import example from './example.jsx';
+
+t.snapshot(example.toString());

packages/sucrase/test/fixtures/preserve-dynamic-import/main.js

@@ -0,0 +1,3 @@
+export default function loadModule(name) {
+  return import(name);
+}

packages/sucrase/test/snapshots/test.js.md

@@ -8,13 +8,13 @@ Generated by [AVA](https://avajs.dev).
 
 > Snapshot 1
 
-    '() => React.createElement(\'div\', { id: "foo", __self: this, __source: {fileName: _jsxFileName, lineNumber: 1}}, "hello world" )'
+    '() => React.createElement(\'div\', { id: "foo", __self: undefined, __source: {fileName: _jsxFileName, lineNumber: 1}}, "hello world" )'
 
 ## converts jsx with custom jsxPragma
 
 > Snapshot 1
 
-    '() => FakeReactCreateElement(\'div\', { id: "foo", __self: this, __source: {fileName: _jsxFileName, lineNumber: 1}}, "hello world" )'
+    '() => FakeReactCreateElement(\'div\', { id: "foo", __self: undefined, __source: {fileName: _jsxFileName, lineNumber: 1}}, "hello world" )'
 
 ## converts typescript
 
@@ -54,20 +54,20 @@ Generated by [AVA](https://avajs.dev).
 
 > Snapshot 1
 
-    '() => React.createElement(\'div\', { id: "foo", __self: this, __source: {fileName: _jsxFileName$4, lineNumber: 1}}, "hello world" )'
+    '() => React.createElement(\'div\', { id: "foo", __self: undefined, __source: {fileName: _jsxFileName$4, lineNumber: 1}}, "hello world" )'
 
 > Snapshot 2
 
-    '() => React.createElement(\'div\', { id: "example-b", __self: this, __source: {fileName: _jsxFileName$3, lineNumber: 1}}, "hello world (a second time)"    )'
+    '() => React.createElement(\'div\', { id: "example-b", __self: undefined, __source: {fileName: _jsxFileName$3, lineNumber: 1}}, "hello world (a second time)"    )'
 
 > Snapshot 3
 
-    '() => React.createElement(\'div\', { id: "foo", __self: this, __source: {fileName: _jsxFileName$2, lineNumber: 1}}, "hello world" )'
+    '() => React.createElement(\'div\', { id: "foo", __self: undefined, __source: {fileName: _jsxFileName$2, lineNumber: 1}}, "hello world" )'
 
 > Snapshot 4
 
-    '() => React.createElement(\'div\', { id: "foo", __self: this, __source: {fileName: _jsxFileName$1, lineNumber: 1}}, "hello world" )'
+    '() => React.createElement(\'div\', { id: "foo", __self: undefined, __source: {fileName: _jsxFileName$1, lineNumber: 1}}, "hello world" )'
 
 > Snapshot 5
 
-    '() => React.createElement(\'div\', { id: "foo", __self: this, __source: {fileName: _jsxFileName, lineNumber: 1}}, "hello world" )'
+    '() => React.createElement(\'div\', { id: "foo", __self: undefined, __source: {fileName: _jsxFileName, lineNumber: 1}}, "hello world" )'

packages/sucrase/test/snapshots/test.js.snap

@@ -17,7 +17,6 @@ process.chdir(__dirname);
 function getBundle(input, sucraseOptions, rollupOptions) {
   return rollup({
     input,
-    context: 'this',
     plugins: [sucrase(sucraseOptions)],
     ...rollupOptions
   });
@@ -108,3 +107,39 @@ test('converts typescript jsx ("tsx")', async (t) => {
 
   return testBundle(t, bundle);
 });
+
+test('converts jsx with jsxImportSource', async (t) => {
+  const bundle = await getBundle(
+    'fixtures/jsx-import-source/main.js',
+    { transforms: ['jsx'], jsxRuntime: 'automatic', jsxImportSource: 'preact' },
+    { external: ['preact/jsx-dev-runtime'] }
+  );
+  const { output } = await bundle.generate({ format: 'cjs', exports: 'auto' });
+  const [{ code }] = output;
+  t.regex(code, /require\(['"]preact\/jsx-dev-runtime['"]\)/);
+  t.notRegex(code, /['"]react\/jsx-dev-runtime['"]/);
+});
+
+test('preserveDynamicImport keeps import() expression', async (t) => {
+  const bundle = await getBundle('fixtures/preserve-dynamic-import/main.js', {
+    transforms: ['imports'],
+    preserveDynamicImport: true
+  });
+  const { output } = await bundle.generate({ format: 'es' });
+  const [{ code }] = output;
+  t.regex(code, /import\(/);
+});
+
+test('injectCreateRequireForImportRequire emits createRequire', async (t) => {
+  const bundle = await getBundle(
+    'fixtures/inject-create-require/main.ts',
+    {
+      transforms: ['typescript'],
+      injectCreateRequireForImportRequire: true
+    },
+    { external: ['foo', 'module'] }
+  );
+  const { output } = await bundle.generate({ format: 'es' });
+  const [{ code }] = output;
+  t.regex(code, /createRequire/);
+});