docs(en): merge rollup/master into rollup-docs-cn/master @ b47bdabe#205
Closed
docschina-bot wants to merge 10 commits into
Closed
docs(en): merge rollup/master into rollup-docs-cn/master @ b47bdabe#205docschina-bot wants to merge 10 commits into
docschina-bot wants to merge 10 commits into
Conversation
* chore(deps): lock file maintenance * Resolve audit * fix: pin stacker to 0.1.23 and windows-sys to 0.59.0 in Cargo.lock stacker 0.1.24 requires windows-sys >=0.60 which dropped windows_x86_64_gnu. That crate provided the static import library supplying __imp_OpenProcessToken and friends that libmimalloc-sys2 needs on windows-gnu. Pin stacker to 0.1.23 (which accepts windows-sys 0.59.x) so the arch crates are restored and the windows-gnu build links successfully. --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lukas Taegert-Atkinson <lukas.taegert-atkinson@tngtech.com>
Co-authored-by: Lukas Taegert-Atkinson <lukastaegert@users.noreply.github.com>
fix(deps): update swc monorepo Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…360)
PR #5947 added "exports" to the universal RESERVED_NAMES set, which
caused every variable or parameter named "exports" to be renamed to
"exports$1" in any scope, even when no conflict exists with the output
format's runtime "exports" identifier. Because eval strings are not
rewritten, this silently broke code like:
(unused, exports) => {
console.log(exports.bar);
eval('exports.bar = 1');
}
where the parameter was renamed but the eval argument was not. The same
over-aggressive rename also applied to unrelated nested bindings in ES
output, which has no runtime "exports" at all.
This change removes "exports" from RESERVED_NAMES and restores the
system-format-specific check in ChildScope.addUsedOutsideNames so that
nested scopes in SystemJS output still treat "exports" as used when
they reference an outer exported binding. Top-level protection for
CJS/AMD/UMD/IIFE/SYSTEM output is unchanged: RESERVED_USED_NAMES in
Chunk.ts still seeds the chunk-level usedNames with "exports", and
reassigned exports still carry renderBaseName === "exports" which
propagates into nested scopes via getBaseVariableName().
The deconflictTopLevelVariables cache from PR #5947 is untouched, so
its performance benefits are preserved; a benchmark that reliably sees
the PR's generate-time speedup (~20% vs pre-PR) shows no regression
from this change.
Fixes #6357
Made-with: Cursor
Co-authored-by: Lukas Taegert-Atkinson <lukastaegert@users.noreply.github.com>
This should be revisited from time to time.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
❌ Deploy Preview for relaxed-alfajores-47dd1b failed.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #205 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 274 274
Lines 10790 10795 +5
Branches 2882 2883 +1
=======================================
+ Hits 10655 10660 +5
Misses 92 92
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
此 PR 自动生成。
合并 rollup/rollup 的修改至本仓库（@ b47bdab）
以下文件存在冲突，可能需要重新翻译：
请解决所有冲突后提交到此 pull request，可直接在 Github 修改、切换到 sync-b47bdabe 分支进行修改或者使用 Github Desktop 拉取此 pr 修改并提交。
禁止使用 Squash Merge 来合并此 Pull Request！
使用该操作会导致上游仓库的内容丢失，并致使下一次合并产生冲突。