feat(ci): add Arbitrum Chain Security Scanner — wolf-pack multi-chain…#195
Open
romanchaa997 wants to merge 1 commit into
Open
feat(ci): add Arbitrum Chain Security Scanner — wolf-pack multi-chain…#195romanchaa997 wants to merge 1 commit into
romanchaa997 wants to merge 1 commit into
Conversation
… scanning Signed-off-by: Igor <romanchaa997@gmail.com>
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
❌ Deploy Preview for audityzer failed. Why did it fail? →
|
❌ Deploy Preview for audityzer-security-platform failed. Why did it fail? →
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/arbitrum-scan.yml">
<violation number="1" location=".github/workflows/arbitrum-scan.yml:8">
P3: `scan_depth` is declared for manual runs but never used, so changing it has no effect.</violation>
<violation number="2" location=".github/workflows/arbitrum-scan.yml:50">
P2: `--filter-paths` is configured with commas instead of regex alternation, so `test`/`lib` may not be excluded from Slither results.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| slither . \ | ||
| --json reports/arbitrum/slither-report.json \ | ||
| --sarif reports/arbitrum/slither.sarif \ | ||
| --filter-paths "node_modules,test,lib" \ |
Contributor
There was a problem hiding this comment.
P2: --filter-paths is configured with commas instead of regex alternation, so test/lib may not be excluded from Slither results.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/arbitrum-scan.yml, line 50:
<comment>`--filter-paths` is configured with commas instead of regex alternation, so `test`/`lib` may not be excluded from Slither results.</comment>
<file context>
@@ -0,0 +1,93 @@
+ slither . \
+ --json reports/arbitrum/slither-report.json \
+ --sarif reports/arbitrum/slither.sarif \
+ --filter-paths "node_modules,test,lib" \
+ --exclude-informational \
+ 2>&1 | tee reports/arbitrum/slither-output.txt || true
</file context>
| - cron: '0 7 * * 2' | ||
| workflow_dispatch: | ||
| inputs: | ||
| scan_depth: |
Contributor
There was a problem hiding this comment.
P3: scan_depth is declared for manual runs but never used, so changing it has no effect.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/arbitrum-scan.yml, line 8:
<comment>`scan_depth` is declared for manual runs but never used, so changing it has no effect.</comment>
<file context>
@@ -0,0 +1,93 @@
+ - cron: '0 7 * * 2'
+ workflow_dispatch:
+ inputs:
+ scan_depth:
+ description: 'Scan depth: quick | full'
+ required: false
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… scanning
Summary by cubic
Adds an Arbitrum chain security scanner workflow that runs Slither and Foundry fork tests on a schedule and on demand, uploads SARIF to code scanning, and publishes reports and a step summary.
New Features
.github/workflows/arbitrum-scan.ymlscheduled weekly (Tue 07:00 UTC) and manual (scan_depthinput).slither-analyzer@0.10.4and Foundry (nightly) viafoundry-rs/foundry-toolchain.node_modules,test,lib) and uploads SARIF viagithub/codeql-action/upload-sarif(categoryslither-arbitrum).forge testagainst an Arbitrum fork (test/arbitrum/**) and saves JSON results.Migration
ARBITRUM_RPC_URL(required).test/arbitrum/**to enable fork tests (optional).Written for commit bb3008f. Summary will update on new commits.