ci: drive Windows DLL bundle from a curated seed list file

Move the bundled-library list out of the bash script into
windows/runtime-libraries.txt, which doubles as user-facing reference
and the build script's input. Emit the exact resolved closure to
<binding-dir>/bundled-dlls.txt at build time.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: romgrk

scripts/windows-bundle-runtime.sh

@@ -5,46 +5,58 @@
 # Make a freshly-built Windows prebuilt self-contained so it can be used WITHOUT
 # MSYS2/MinGW or any compiler on the target machine. We copy the addon's entire
 # transitive MinGW DLL closure next to the .node, plus the GObject-Introspection
-# typelibs it needs at runtime.
+# typelibs and runtime data it needs at runtime.
+#
+# The set of bundled libraries is driven by the curated seed list
+# windows/runtime-libraries.txt (also a user-facing reference). The exact
+# resolved DLL set is written to <binding-dir>/bundled-dlls.txt.
 #
 # Run inside the MINGW64 shell, after building.
 #
 #   ./scripts/windows-bundle-runtime.sh lib/binding/node-v127-win32-x64
 #
 set -euo pipefail
 
-BINDING_DIR="${1:?usage: windows-bundle-runtime.sh <binding-dir>}"
+SCRIPT_DIR=$(cd "$(dirname "$0")" && pwd)
+
+BINDING_DIR="${1:?usage: windows-bundle-runtime.sh <binding-dir> [runtime-libraries.txt]}"
+# The curated seed list lives in a text file so it doubles as user-facing
+# reference (windows/runtime-libraries.txt). Override with $2 if needed.
+LIBS_FILE="${2:-$SCRIPT_DIR/../windows/runtime-libraries.txt}"
+# MinGW bin dir the seed names resolve against.
+MB="${MINGW_BIN:-/mingw64/bin}"
+
 NODE_FILE="$BINDING_DIR/node_gtk.node"
 
 if [ ! -f "$NODE_FILE" ]; then
   echo "error: $NODE_FILE not found"
   ls -la "$BINDING_DIR" || true
   exit 1
 fi
+if [ ! -f "$LIBS_FILE" ]; then
+  echo "error: seed list $LIBS_FILE not found"
+  exit 1
+fi
 
 # GObject-Introspection loads each namespace's shared library at runtime via
 # g_module_open() when you call gi.require('Gtk', ...). Those libraries
-# (libgio, libgtk, libgdk, libpango, libatk, libgdk_pixbuf, ...) are NOT linked
-# by node_gtk.node, so ntldd on the addon alone misses them. We therefore seed
-# the closure from the addon AND from the GTK runtime libraries themselves.
-MB=/mingw64/bin
-# Seed from the addon AND from every runtime library a real GTK4/Adwaita app
-# pulls in (the quilx target: Gtk4 + Adw + GtkSourceView5 + Pango + GdkPixbuf +
-# Graphene). Missing entries are skipped, so a few GTK3 names are kept too for
-# robustness.
-ENTRY_LIBS=(
-  "$NODE_FILE"
-  "$MB/libgirepository-1.0-1.dll"
-  "$MB/libgio-2.0-0.dll"
-  "$MB/libgtk-4-1.dll"
-  "$MB/libadwaita-1-0.dll"
-  "$MB/libgtksourceview-5-0.dll"
-  "$MB/libpango-1.0-0.dll"
-  "$MB/libpangocairo-1.0-0.dll"
-  "$MB/libgdk_pixbuf-2.0-0.dll"
-  "$MB/libgraphene-1.0-0.dll"
-  "$MB/libcairo-gobject-2.dll"
-)
+# (libgio, libgtk, libgdk, libpango, libgdk_pixbuf, ...) are NOT linked by
+# node_gtk.node, so ntldd on the addon alone misses them. We therefore seed the
+# closure from the addon AND from the GTK runtime libraries listed in LIBS_FILE.
+echo "## Seed libraries from $LIBS_FILE"
+ENTRY_LIBS=("$NODE_FILE")
+while IFS= read -r line; do
+  # strip comments and surrounding whitespace; skip blanks
+  name="${line%%#*}"
+  name="$(echo "$name" | tr -d '[:space:]')"
+  [ -z "$name" ] && continue
+  if [ -f "$MB/$name" ]; then
+    ENTRY_LIBS+=("$MB/$name")
+    echo "  - $name"
+  else
+    echo "  (skip missing seed $name)"
+  fi
+done < "$LIBS_FILE"
 
 echo "## Computing recursive DLL closure for the addon + GTK runtime"
 # ntldd -R prints every transitive dependency with its resolved Windows path:
@@ -73,7 +85,21 @@ sort -u /tmp/dll-closure.txt | while IFS= read -r u; do
     copied=$((copied + 1))
   fi
 done
-echo "## DLLs bundled into $BINDING_DIR ($(ls "$BINDING_DIR"/*.dll | wc -l) total)"
+DLL_COUNT=$(ls "$BINDING_DIR"/*.dll 2>/dev/null | wc -l | tr -d ' ')
+echo "## DLLs bundled into $BINDING_DIR ($DLL_COUNT total)"
+
+# Write the exact set that shipped, as a reference manifest (ships in the
+# bundle and the artifact). Generated from the curated seed list above.
+MANIFEST="$BINDING_DIR/bundled-dlls.txt"
+{
+  echo "# bundled-dlls.txt — Windows DLLs shipped with this node-gtk prebuilt."
+  echo "# GENERATED by scripts/windows-bundle-runtime.sh; do not edit by hand."
+  echo "# Edit the curated seed list windows/runtime-libraries.txt instead."
+  echo "# $DLL_COUNT DLLs, expanded from the seed list via 'ntldd -R'."
+  echo "#"
+  ( cd "$BINDING_DIR" && ls -1 *.dll 2>/dev/null | sort )
+} > "$MANIFEST"
+echo "## Wrote manifest $MANIFEST"
 
 echo "## Bundling GObject-Introspection typelibs"
 TYPELIB_SRC=$(pkg-config --variable=typelibdir gobject-introspection-1.0 2>/dev/null || true)

windows/runtime-libraries.txt

@@ -0,0 +1,43 @@
+# windows/runtime-libraries.txt
+#
+# Seed libraries bundled with the node-gtk Windows prebuilt.
+#
+# These are the high-level GObject-Introspection runtime libraries that a
+# GTK4 / Adwaita application loads at run time (via g_module_open when you call
+# gi.require('Gtk', '4.0') etc.). They are NOT linked by node_gtk.node itself,
+# so scanning the addon's own imports does not find them — they must be listed
+# here explicitly.
+#
+# scripts/windows-bundle-runtime.sh reads this file, then uses `ntldd -R` to
+# expand each entry into its full transitive DLL closure (~78 DLLs: harfbuzz,
+# cairo, pixman, fribidi, freetype, zlib, ...) and copies the whole set next to
+# the compiled addon. The exact resolved list that actually ships is written to
+# <binding-dir>/bundled-dlls.txt at build time — read that file to see every DLL.
+#
+# Format:
+#   - one DLL file name per line (no path; resolved against the MinGW bin dir,
+#     e.g. /mingw64/bin)
+#   - lines starting with '#' and blank lines are ignored
+#   - entries that don't exist in the MinGW prefix are skipped with a warning,
+#     so it is safe to list optional libraries
+#
+# To support additional namespaces, add the providing DLL here. For example:
+#   libgstreamer-1.0-0.dll     # GStreamer (gi.require('Gst', '1.0'))
+#   libsoup-3.0-0.dll          # libsoup   (gi.require('Soup', '3.0'))
+# Note: VTE (terminal) has no Windows port and cannot be bundled.
+
+# --- GObject-Introspection core ---
+libgirepository-1.0-1.dll
+libgio-2.0-0.dll
+
+# --- GTK4 stack (quilx target) ---
+libgtk-4-1.dll
+libadwaita-1-0.dll
+libgtksourceview-5-0.dll
+
+# --- text / graphics ---
+libpango-1.0-0.dll
+libpangocairo-1.0-0.dll
+libgdk_pixbuf-2.0-0.dll
+libgraphene-1.0-0.dll
+libcairo-gobject-2.dll